Skip to content

Fix image alignment in ready page in some contexts#10780

Merged
djhi merged 1 commit intomasterfrom
fix-ready-page-alignment
Jun 11, 2025
Merged

Fix image alignment in ready page in some contexts#10780
djhi merged 1 commit intomasterfrom
fix-ready-page-alignment

Conversation

@Madeorsk
Copy link
Copy Markdown
Contributor

Problem

Images in buttons are not centered. I think it only occurs when setting up React Admin without using create-react-admin. I saw this using shadcn-admin-kit.

ready page with misaligned images in buttons

Solution

Add margin auto and ensure display block (display block wasn't actually required in my case but it's probably safer to enforce it).

How To Test

Setup a shadcn admin kit project with this app:

import { Admin } from "@/components/admin";

function App() {
  return <Admin></Admin>;
}

export default App;

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • [ ] The PR includes unit tests (if not possible, describe why)
  • [ ] The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

@djhi djhi added this to the 5.8.5 milestone Jun 11, 2025
@djhi djhi merged commit 1768f81 into master Jun 11, 2025
15 checks passed
@djhi djhi deleted the fix-ready-page-alignment branch June 11, 2025 09:45
@djhi djhi modified the milestones: 5.8.5, 5.9.0 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants