Fix limitation preventing to declare create and show routes from the list view#10782
Merged
Fix limitation preventing to declare create and show routes from the list view#10782
Conversation
djhi
approved these changes
Jun 12, 2025
Contributor
djhi
left a comment
There was a problem hiding this comment.
Awesome stories, great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If a resource declares both a list view and an edit view
Then it's impossible to declare other routes (such as the create or show routes) from within the list view, because they overlap with the route declared for the edit view.
This prevents notably from being able to use a CreateDialog with a regular Edit view.
Hence this note in the EE doc:
Solution
Do not register the edit route if the location matches the create route or the show route.
How To Test
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.