Skip to content

Add disable support for RadioButtonGroupInput and CheckboxGroupInput choices#10821

Merged
djhi merged 12 commits intomarmelab:nextfrom
WiXSL:disable-radiobuttongroupitem-next
Jul 4, 2025
Merged

Add disable support for RadioButtonGroupInput and CheckboxGroupInput choices#10821
djhi merged 12 commits intomarmelab:nextfrom
WiXSL:disable-radiobuttongroupitem-next

Conversation

@WiXSL
Copy link
Copy Markdown
Collaborator

@WiXSL WiXSL commented Jul 2, 2025 •
edited
Loading

Implements #3677

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

@djhi
Copy link
Copy Markdown
Contributor

djhi commented Jul 2, 2025

Thanks! Would you mind adding some tests?

djhi
djhi suggested changes Jul 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 👍

Comment thread packages/ra-ui-materialui/src/input/RadioButtonGroupInput.spec.tsx Outdated
Comment thread docs/RadioButtonGroupInput.md
@WiXSL WiXSL requested a review from djhi July 2, 2025 14:15
djhi
djhi suggested changes Jul 2, 2025
View reviewed changes
Comment thread packages/ra-ui-materialui/src/input/RadioButtonGroupInput.tsx Outdated
Comment thread packages/ra-ui-materialui/src/input/RadioButtonGroupInputItem.tsx Outdated
@WiXSL WiXSL changed the title Add disable support for RadioButtonGroupInput choices Add disable support for RadioButtonGroupInput and CheckboxGroupInput choices Jul 2, 2025
@WiXSL WiXSL requested a review from djhi July 2, 2025 16:43
@djhi
Copy link
Copy Markdown
Contributor

djhi commented Jul 4, 2025

Thanks!

@djhi djhi added this to the 5.10.0 milestone Jul 4, 2025
@djhi djhi merged commit ccf10db into marmelab:next Jul 4, 2025
12 of 14 checks passed
@WiXSL WiXSL deleted the disable-radiobuttongroupitem-next branch July 4, 2025 11:42
@WiXSL WiXSL mentioned this pull request Jul 7, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@djhi djhi djhi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@WiXSL @djhi