Fix useEditController does not pass all variables to useUpdate#10839
Merged
fzaninotto merged 2 commits intomasterfrom Jul 16, 2025
Merged
Fix useEditController does not pass all variables to useUpdate#10839fzaninotto merged 2 commits intomasterfrom
useEditController does not pass all variables to useUpdate#10839fzaninotto merged 2 commits intomasterfrom
Conversation
fzaninotto
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Although
useEditControllerdo pass all variables touseUpdateat declaration time, it actually overrides them at call time. However, it does not pass all of them (previousDatais missing). This is an issue when your dataProvider update function or your side effects depends on the previous values (e.g. depending on the previous status, etc)Solution
Fix
useEditControllerso that it passes everything as expected.How To Test
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.