Skip to content

Fix <ColumnsButton> cannot be used with keyboard#10869

Merged
Madeorsk merged 2 commits intomasterfrom
fix-columns-button-keyboard-usage
Jul 31, 2025
Merged

Fix <ColumnsButton> cannot be used with keyboard#10869
Madeorsk merged 2 commits intomasterfrom
fix-columns-button-keyboard-usage

Conversation

@djhi
Copy link
Copy Markdown
Contributor

@djhi djhi commented Jul 30, 2025

Problem

  • Although it's possible to open the <ColumnsButton> menu with space, it's impossible to reach its items using the keyboard.
  • It also produce invalid HTML when adding the filter (not rendered inside a li element)

Solution

  • Make it possible to reach its items using the keyboard.
  • Produce valid HTML

Note: Drag and dropping the items to reorder columns has not been implemented yet.

How To Test

  • Story
  • Click in the background around the list t ofocus the story iframe
  • Press Tab until the <ColumnsButton> is active
  • Press Space to open its menu
  • Press Tab to loop through its items, toggling them with Space
  • Press Escape to close the menu

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature

@djhi djhi added RFR Ready For Review WIP Work In Progress and removed RFR Ready For Review labels Jul 30, 2025
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Jul 30, 2025
@Madeorsk Madeorsk self-requested a review July 31, 2025 13:50
@Madeorsk Madeorsk added this to the 5.10.1 milestone Jul 31, 2025
@Madeorsk Madeorsk merged commit 91d8852 into master Jul 31, 2025
15 checks passed
@Madeorsk Madeorsk deleted the fix-columns-button-keyboard-usage branch July 31, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFR Ready For Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants