Conversation
… may pass invalid parameters to the mutation ## Problem After #10857, when passing parameters at declaration time to a mutation hook in `optimistic` or `undoable` mode, those params may be modified by the side effects before the actual mutation is called. For instance, if you pass the `selectedIds` from the `ListContext` to a `useUpdateMany` hook and use the `useUnselectAll` hook to reset the `selectedIds` in the `onSuccess` side effect, then the actual mutation will be called with an empty array of ids. ## Solution Keep the params in an additional ref that is freezed once the `mutate` callback is called.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where mutations using optimistic or undoable mode would receive stale parameters when side effects modify the parameters between the mutation call and execution. The fix introduces a new ref to preserve parameters at the exact moment the mutation is called.
- Adds
paramsAtExecutionTimeRefto freeze parameters whenmutateis called - Updates all optimistic and undoable mutation paths to use the frozen parameters
- Preserves existing behavior for pessimistic mutations and declaration-time parameter updates
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/ra-core/src/dataProvider/useMutationWithMutationMode.ts |
Implements the core fix by adding parameter freezing logic and updating mutation execution paths |
packages/ra-core/src/dataProvider/useMutationWithMutationMode.spec.tsx |
Adds test coverage to verify parameters are preserved correctly in optimistic mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
slax57
reviewed
Oct 6, 2025
slax57
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #10857, when passing parameters at declaration time to a mutation hook in
optimisticorundoablemode, those params may be modified by the side effects before the actual mutation is called.For instance, if you pass the
selectedIdsfrom theListContextto auseUpdateManyhook and use theuseUnselectAllhook to reset theselectedIdsin theonSuccessside effect, then the actual mutation will be called with an empty array of ids.You can see the issue like this:
updateManySolution
Keep the params in an additional ref that is freezed once the
mutatecallback is called.How To Test
make runupdateManyAdditional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature