Skip to content

Fix ColumnsSelector search input should stay fixed above menu list#11114

Merged
djhi merged 3 commits intomasterfrom
fix-columnselector-col-order
Jan 19, 2026
Merged

Fix ColumnsSelector search input should stay fixed above menu list#11114
djhi merged 3 commits intomasterfrom
fix-columnselector-col-order

Conversation

@WiXSL
Copy link
Copy Markdown
Collaborator

@WiXSL WiXSL commented Jan 15, 2026

Problem

Items in ColumnsSelector component can be placed above the search input.
This disrupts expected UX.

Solution

Modify markup to fix the position of the search input

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

@WiXSL WiXSL added the RFR Ready For Review label Jan 15, 2026
@fzaninotto
Copy link
Copy Markdown
Member

Strange: in stories (e.g., http://localhost:9011/?path=/story/ra-ui-materialui-list-columnsbutton--label-types), the search box appears sticked to the top of the popover.

image

This doesn't seem to happen in any of the demos, where there is proper top padding in the popover.

Any idea why?

@WiXSL
Copy link
Copy Markdown
Collaborator Author

WiXSL commented Jan 16, 2026

Any idea why?

I believe its because Storybook renders the component with a very minimal theme and without the app-level overrides used by the demo.
The top spacing used to come from the MenuList. Once the search input was moved outside of the MenuList, that padding no longer applied to it.
In the demo, there’s still extra padding coming from theme/component overrides or global styles around the popover.

I've added some padding.

Before/After this PR (Story):
story

Before/After this PR (Demo):
demo

@djhi djhi added this to the 5.13.7 milestone Jan 19, 2026
@djhi djhi merged commit 6491757 into master Jan 19, 2026
15 checks passed
@djhi djhi deleted the fix-columnselector-col-order branch January 19, 2026 16:07
@slax57 slax57 modified the milestones: 5.13.7, 5.14.0 Jan 23, 2026
@slax57 slax57 changed the title [Fix] Keep ColumnsSelector search input fixed above menu list Fix ColumnsSelector search input should stay fixed above menu list Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFR Ready For Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants