[chore] Stabilize flaky tests by WiXSL · Pull Request #11121 · marmelab/react-admin

WiXSL · 2026-01-17T19:08:20Z

Problem

Some tests are flaky.
Locally, these tests tend to fail regularly.

Solution

Improve the code to stabilize such tests.
Now these tests always pass locally as well.

Additional Checks

The PR targets master for a bugfix or a documentation fix, or next for a feature
The PR includes unit tests (if not possible, describe why)
The PR includes one or several stories (if not possible, describe why)
The documentation is up to date

WiXSL · 2026-01-17T19:19:52Z

+                expect(screen.queryByText('World')).not.toBeNull();
+                expect(screen.queryByText('mutating')).toBeNull();
+            },
+            { timeout: 3000 }


Increased waitFor timeout to cover the dataProvider’s 1000 ms delay; the assertion was right at the edge and could fail due to CI jitter

We prefer to pass a custom dataProvider where we manually resolve the promises. example:

react-admin/packages/ra-core/src/auth/CanAccess.spec.tsx

Lines 14 to 32 in eca0c1b

it('renders nothing while loading by default', async () => {

let resolveCheckAuth;

const authProvider: AuthProvider = {

login: () => Promise.reject('bad method'),

logout: () => Promise.reject('bad method'),

checkAuth: () => Promise.reject('bad method'),

checkError: () => Promise.reject('bad method'),

getPermissions: () => Promise.reject('bad method'),

canAccess: () =>

new Promise(resolve => {

resolveCheckAuth = resolve;

}),

};

const { container } = render(<Basic authProvider={authProvider} />);

expect(container.textContent).toEqual('');

expect(screen.queryByText('protected content')).toBeNull();

resolveCheckAuth(true);

await screen.findByText('protected content');

});

And we configured a large timeout globally in jest config and setup files. We should probably remove the explicit timeout as it may override the large default one

WiXSL · 2026-01-17T19:21:16Z

        it('when optimistic, it accepts middlewares and displays error and error side effects when dataProvider promise rejects', async () => {
            jest.spyOn(console, 'error').mockImplementation(() => {});
-            render(<WithMiddlewaresErrorOptimistic timeout={10} />);
+            render(<WithMiddlewaresErrorOptimistic timeout={200} />);


Raised the optimistic story timeout so the success state is observable before the reject; the error previously landed too fast and intermittently broke the assert

WiXSL · 2026-01-17T19:22:07Z

        await waitFor(() => {
-            // 9 because War and Peace is handled separately
-            expect(screen.queryAllByLabelText('Delete')).toHaveLength(9);
+            expect(screen.queryAllByLabelText('Delete').length).toBeGreaterThan(


Avoided asserting an exact count of delete buttons (pagination/render-dependent) and instead check that at least one appears; less brittle

WiXSL · 2026-01-17T19:22:44Z

        await screen.findByText('9 items selected');
        expect(screen.queryByRole('button', { name: 'Select all' })).toBeNull();
-    });
+    }, 10000);


Increased the timeout for the specific test; the flow depends on multiple renders and was sensitive to the default 5s limit in CI

WiXSL · 2026-01-17T19:23:21Z

        });

        it('should close the filter menu on removing all filters', async () => {
+            const user = userEvent.setup();


Switched from counting global checkboxes to asserting pagination text and used userEvent with await; avoids races from async renders and MUI portals

WiXSL · 2026-01-17T19:24:35Z

    });

    it('should not reapply previous filter form values when clearing nested AutocompleteArrayInput', async () => {
+        const user = userEvent.setup();


Select Autocomplete options via userEvent and keyboard navigation instead of matching raw text; avoids failures due to MUI portal/virtualized rendering

WiXSL · 2026-01-17T19:26:26Z

        });
    });

    describe('"Select all" button', () => {


Synchronize on real content (‘War and Peace’) instead of checkbox counts and allow more time per test; reduces flakes from slow loads and DOM timing

djhi

Neat!

djhi · 2026-01-19T16:21:31Z

                screen.queryByRole('button', { name: 'Select all' })
            ).toBeNull();
-        });
+        }, 10000);


This is probably not needed anymore with the new config, right? Same for the others

fix: stabilize flaky tests

1caa52d

vercel Bot deployed to Preview – react-admin-storybook January 17, 2026 19:09 View deployment

WiXSL added the RFR Ready For Review label Jan 17, 2026

WiXSL commented Jan 17, 2026

View reviewed changes

applied review

f2db766

vercel Bot deployed to Preview – react-admin-storybook January 19, 2026 12:54 View deployment

WiXSL added 2 commits January 19, 2026 11:13

increase global jest/testing-library timeouts

807355d

adjust eslint rules for test setup files

a65bd89

vercel Bot deployed to Preview – react-admin-storybook January 19, 2026 14:20 View deployment

WiXSL requested a review from djhi January 19, 2026 16:20

djhi suggested changes Jan 19, 2026

View reviewed changes

remove manual timeouts

0aadb62

WiXSL requested a review from djhi January 19, 2026 16:30

vercel Bot deployed to Preview – react-admin-storybook January 19, 2026 16:33 View deployment

djhi approved these changes Jan 19, 2026

View reviewed changes

djhi added this to the 5.13.7 milestone Jan 19, 2026

djhi merged commit b9d6ff0 into master Jan 19, 2026
15 checks passed

djhi deleted the fix-flaky-tests branch January 19, 2026 16:50

slax57 modified the milestones: 5.13.7, 5.14.0 Jan 23, 2026

slax57 changed the title ~~[Fix] Stabilize flaky tests~~ [chore] Stabilize flaky tests Jan 23, 2026

	it('renders nothing while loading by default', async () => {
	let resolveCheckAuth;
	const authProvider: AuthProvider = {
	login: () => Promise.reject('bad method'),
	logout: () => Promise.reject('bad method'),
	checkAuth: () => Promise.reject('bad method'),
	checkError: () => Promise.reject('bad method'),
	getPermissions: () => Promise.reject('bad method'),
	canAccess: () =>
	new Promise(resolve => {
	resolveCheckAuth = resolve;
	}),
	};
	const { container } = render(<Basic authProvider={authProvider} />);
	expect(container.textContent).toEqual('');
	expect(screen.queryByText('protected content')).toBeNull();
	resolveCheckAuth(true);
	await screen.findByText('protected content');
	});

Uh oh!

Conversation

WiXSL commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Additional Checks

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

djhi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

WiXSL commented Jan 17, 2026 •

edited

Loading