Skip to content

Add default empty component and i18n messages to ListGuesser#11165

Merged
slax57 merged 4 commits intomasterfrom
guesser-i18n-translations
Feb 18, 2026
Merged

Add default empty component and i18n messages to ListGuesser#11165
slax57 merged 4 commits intomasterfrom
guesser-i18n-translations

Conversation

@WiXSL
Copy link
Copy Markdown
Collaborator

@WiXSL WiXSL commented Feb 17, 2026

Additional Checks

  • Added ListGuesser empty prop
  • Added GuesserEmpty component and apply i18n messages to it
  • Added ListGuesser empty story
  • Added ListGuesser empty test
  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Copy link
Copy Markdown
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These messages aren't used anywhere in the repo (I know they're used by shadcn admin kit). We should update the ListGuesser to take advantage of them.

@slax57 slax57 added this to the 5.14.3 milestone Feb 18, 2026
@slax57 slax57 merged commit e43233f into master Feb 18, 2026
15 of 16 checks passed
@slax57 slax57 deleted the guesser-i18n-translations branch February 18, 2026 16:55
@slax57 slax57 changed the title Add guesser empty i18n messages Add default empty component and i18n messages to ListGuesser Feb 18, 2026
className?: string;
}

const GUESSER_EMPTY_PREFIX = 'RaGuesserEmpty';
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should have been RaListGuesserEmpty (we never know if there are going to be other empty guessers)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 32495d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFR Ready For Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants