Fix RichTextInput does not allow nesting unordered and ordered lists#11179
Merged
slax57 merged 1 commit intomarmelab:masterfrom Mar 4, 2026
Merged
Conversation
frlruehle
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes nested ordered/bulleted list toggling in ra-input-rich-text by making list toolbar state/actions target the innermost active list node, addressing issue #11178.
Changes:
- Update list toggle handler to toggle the selected format directly, and to toggle off the innermost list when unselecting.
- Replace “last active list in
ListValues” detection with a selection-based “innermost list” lookup. - Add
getInnermostListTypehelper using Tiptap’sfindParentNode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slax57
approved these changes
Mar 4, 2026
Contributor
slax57
left a comment
slax57
left a comment
There was a problem hiding this comment.
Works like a charm, thanks!
slax57
changed the title
RichTextInput does not allow nesting unordered and ordered lists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #11178
Solution
Finding innermost list type for toggling the buttons.
How To Test
Go to react demo page and nest ordered into bullet lists and vice versa.
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.