[Fix] Prevent stale nested field values when re-adding items in SimpleFormIterator#11201
Merged
ThieryMichel merged 2 commits intomasterfrom Mar 26, 2026
Merged
Conversation
ThieryMichel
requested changes
Mar 26, 2026
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIterator.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIterator.spec.tsx
Outdated
Show resolved
Hide resolved
| const records = | ||
| useWatch({ | ||
| name: finalSource, | ||
| }) ?? get(record, finalSource); |
Contributor
There was a problem hiding this comment.
Why do you need this ? It adds extra rerenders, and removing it do not break any tests, nor does it reintroduce the bug.
The fix in SimpleFormInterator seems sufficient.
Collaborator
Author
There was a problem hiding this comment.
You are right! Based on my earlier testing, I thought this change was needed. I re-ran the tests now and the fix still works without it, so we can avoid those extra re-renders.
ThieryMichel
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SimpleFormIteratorreused values from a removed item when adding a new one back, for nested fields.Solution
How To Test
1- Open a form with an ArrayInput
2- Use nested sources
3- Remove an item
4- Add a new item
5- Verify the new row is empty and does not reuse the removed values
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature