Fix FormDataConsumer to avoid ReDoS in source detection#11224
Merged
Conversation
slax57
requested changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates FormDataConsumer’s “array item source” detection to avoid a potentially unsafe regular expression pattern flagged by CodeQL, while preserving the existing behavior used to infer scopedFormData when inside iterator-like components.
Changes:
- Replace
/.+\.\d+$/matching viaexec()with a safer anchored suffix check (/\.\d+$/) viatest(). - Introduce a small helper (
getArraySource) to centralize and clarify the detection logic. - Continue using the detected array-item source path to compute
scopedFormDatavialodash/get.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slax57
approved these changes
Mar 31, 2026
FormDataConsumer to avoid ReDoS in source detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FormDataConsumerWhy
GitHub code scanning reports alert #44 (
Polynomial regular expression used on uncontrolled data) onFormDataConsumer.The previous regex used a greedy repeated token before the numeric suffix. This change keeps the same intent while avoiding the backtracking pattern that CodeQL flagged.
Testing
yarn test-unit --runTestsByPath packages/ra-core/src/form/FormDataConsumer.spec.tsx