plugin/gcs: enable Service Account impersonation and document ADC auth#119
Open
bschaatsbergen wants to merge 13 commits into
Open
plugin/gcs: enable Service Account impersonation and document ADC auth#119bschaatsbergen wants to merge 13 commits into
bschaatsbergen wants to merge 13 commits into
Conversation
This is a result of `make generate`
There was a problem hiding this comment.
Pull request overview
This PR updates the Google Cloud Storage (GCS) plugin to support keyless authentication via Application Default Credentials (ADC) by default, adds service account impersonation support, and refreshes related documentation to steer users away from long-lived exported service account keys.
Changes:
- Add
impersonate_service_accountsupport to the GCS provider and log the resolved credential source. - Switch GCS authentication behavior to prefer ADC when explicit key material isn’t provided.
- Update plugin documentation (GCS and multiple other plugins) to adjust authentication guidance and UI-guide linking.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| web/docs/plugin-docs/Google Cloud Storage.md | Reworks authentication docs to emphasize ADC/keyless flows and documents auth precedence/impersonation. |
| web/docs/docs/Plugins/Google Cloud Storage.md | Mirrors the GCS auth documentation updates and adds impersonate_service_account to the config table. |
| internal/plugin/providers/gcs/source.go | Implements ADC-default auth option resolution plus service account impersonation support. |
| internal/plugin/providers/gcs/source_test.go | Adds tests for impersonation config parsing and credential-source precedence behavior. |
| web/docs/docs/Plugins/Trino.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/SQS.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/SNS.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/S3.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Redpanda.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Redis.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/PostgreSQL.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/OpenSearch.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/OpenAPI.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/NATS.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/MySQL.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/MongoDB.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Lambda.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Kafka.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Iceberg.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Glue.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Elasticsearch.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/DynamoDB.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/DuckDB.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Delta Lake.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/DBT.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Confluent Cloud.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/ClickHouse.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/BigQuery.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Azure Blob Storage.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/AsyncAPI.md | Updates UI guide link wiring (docId → href). |
| web/docs/docs/Plugins/Airflow.md | Updates UI guide link wiring (docId → href). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces SA impersonation and documents the use of ADC as Google recommends against persisted long-living keys.