Reduce memory usage by avoiding issubclass(Schema) (#703)

* Reduce memory usage by avoiding issubclass(Schema)

issubclass() calls against Schema triggered
ABCMeta.__subclasscheck__ calls which adds to an internal weaksets,
_abc_cache, _abc_negative_cache

* tiny optimization

* Update changelog

Author: sloria

CHANGELOG.rst

@@ -1,8 +1,12 @@
 Changelog
 ---------
 
-unreleased
-++++++++++
+1.5.0 (unreleased)
+++++++++++++++++++
+
+Bug fixes:
+
+* Fix memory usage regression from 1.4.1 (1.4.2 didn't address the root cause) (:issue:`665`).
 
 Other changes:
 

src/marshmallow_sqlalchemy/schema.py

@@ -1,11 +1,10 @@
 from __future__ import annotations
 
-import inspect
 from typing import TYPE_CHECKING, Any, cast
 
 import sqlalchemy as sa
 from marshmallow.fields import Field
-from marshmallow.schema import Schema, SchemaMeta, SchemaOpts, _get_fields
+from marshmallow.schema import Schema, SchemaMeta, SchemaOpts
 
 from .convert import ModelConverter
 from .exceptions import IncorrectSchemaTypeError
@@ -171,18 +170,21 @@ def _maybe_filter_foreign_keys(
                 if column.foreign_keys
             }
 
-            non_auto_schema_bases = [
-                base
-                for base in inspect.getmro(klass)
-                if issubclass(base, Schema)
-                and not issubclass(base, SQLAlchemyAutoSchema)
-            ]
-
-            # Pre-compute declared fields only once
-            declared_fields: set[Any] = set()
-            for base in non_auto_schema_bases:
-                base_fields = getattr(base, "_declared_fields", base.__dict__)
-                declared_fields.update(name for name, _ in _get_fields(base_fields))
+            # Collect fields explicitly declared in non-AutoSchema bases.
+            # XXX: Avoid issubclass(base, Schema) because it causes quadratic
+            # ABCMeta cache growth with many schema classes (#665).
+            declared_fields: set[str] = set()
+            for base in klass.__mro__:
+                if base is object:
+                    break
+                opts_cls = getattr(base, "OPTIONS_CLASS", None)
+                if opts_cls is not None and issubclass(
+                    opts_cls, SQLAlchemyAutoSchemaOpts
+                ):
+                    continue
+                base_declared = base.__dict__.get("_declared_fields")
+                if base_declared:
+                    declared_fields.update(base_declared.keys())
 
             return [
                 (name, field)