fix: handle platform-specific error messages in overflow timestamp test#3000
Open
andrianbalanesq wants to merge 1 commit into
Open
fix: handle platform-specific error messages in overflow timestamp test#3000andrianbalanesq wants to merge 1 commit into
andrianbalanesq wants to merge 1 commit into
Conversation
The test_from_timestamp_with_overflow_value test was failing on Windows because datetime.fromtimestamp raises OSError on Windows (caught by from_timestamp and re-raised as 'Error converting value to datetime'), while the test regex only matched 'out of range' and 'year must be in 1..9999' (the messages from uncaught ValueError on Linux). Updated the regex to also match 'Timestamp is too large' (from caught OverflowError) and 'Error converting value to datetime' (from caught OSError on Windows). Fixes marshmallow-code#2999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test_from_timestamp_with_overflow_value test was failing on Windows because datetime.fromtimestamp raises OSError on Windows (caught by from_timestamp and re-raised as ValueError("Error converting value to datetime")), while the test regex only matched messages from uncaught ValueError on Linux.
Updated the regex to match all platform-specific error messages.
Fixes #2999