Skip to content

fix: handle platform-specific error messages in overflow timestamp test #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrianbalanesq wants to merge 1 commit into
base: dev
Choose a base branch
from
+9 −1
Open

fix: handle platform-specific error messages in overflow timestamp test #3000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,15 @@ def test_from_timestamp_with_negative_value():

def test_from_timestamp_with_overflow_value():
value = 9223372036854775
with pytest.raises(ValueError, match=r"out of range|year must be in 1\.\.9999"):
# The error message varies by platform:
# - Linux: ValueError("year must be in 1..9999") (not caught by from_timestamp)
# - Some platforms: ValueError("... out of range") (not caught by from_timestamp)
# - Some platforms: OverflowError -> ValueError("Timestamp is too large")
# - Windows: OSError -> ValueError("Error converting value to datetime")
with pytest.raises(
ValueError,
match=r"out of range|year must be in 1\.\.9999|Timestamp is too large|Error converting value to datetime",
):
utils.from_timestamp(value)


Expand Down