✨ No basic exception rule

Author: martinsoenen

README.md

@@ -46,6 +46,12 @@ For all available options, please take a look at the PHPStan documentation: **ht
 
 ## Rules
 
+### Boolean Property Naming Rule
+
+*Identifier : martinsoenen.booleanPropertyNaming*
+
+Ensure that a Boolean is always named with an “is” at the beginning of its name, to clarify the condition it represents.
+
 ### Max Line Per Class Rule
 
 *Identifier : martinsoenen.maxLinePerClass*
@@ -58,6 +64,12 @@ Guarantee that a class is no more than 100 lines long, to clearly separate roles
 
 Guarantee that a method is no more than 20 lines long, to separate roles between classes and encourage specification.
 
+### No Basic Exception Rule
+
+*Identifier : martinsoenen.noBasicException*
+
+Ensure that no base exceptions are thrown in order to make custom and specific exceptions everywhere for better maintainability.
+
 ### No Delete Cascade Rule (Laravel)
 
 *Identifier : martinsoenen.noCascadeDeleteLaravel*
@@ -87,9 +99,3 @@ This rule encourages the use of Events & Listeners, whose behavior is similar bu
 
 Prevent `try catch` usage to ensure that the user uses PHP exceptions.  
 This makes the code more readable and errors are handled by the framework if there is one.
-
-### Boolean Property Naming Rule
-
-*Identifier : martinsoenen.booleanPropertyNaming*
-
-Ensure that a Boolean is always named with an “is” at the beginning of its name, to clarify the condition it represents.

src/Rules/NoBasicExceptionRule.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace MartinSoenen\PHPStanRules\Rules;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
+
+class NoBasicExceptionRule implements Rule
+{
+    public function getNodeType(): string
+    {
+        return Node\Expr\Throw_::class;
+    }
+
+    public function processNode(Node $node, Scope $scope): array
+    {
+        if ($node->expr instanceof Node\Expr\New_) {
+            $exceptionClass = $node->expr->class;
+            if ($exceptionClass instanceof Node\Name && $exceptionClass->toString() === 'Exception') {
+                return [
+                    RuleErrorBuilder::message('Basic exceptions are not allowed. Please create a custom Exception instead.')
+                        ->line($node->getLine())
+                        ->identifier('martinsoenen.noBasicException')
+                        ->build()
+                ];
+            }
+        }
+
+        return [];
+    }
+}

tests/Rules/NoBasicExceptionRuleTest.php

@@ -0,0 +1,29 @@
+<?php declare(strict_types = 1);
+
+namespace MartinSoenen\PHPStanRules\Tests\Rules;
+
+use PHPStan\Testing\RuleTestCase;
+use MartinSoenen\PHPStanRules\Rules\NoBasicExceptionRule;
+
+/**
+ * @extends RuleTestCase<NoBasicExceptionRule>
+ */
+class NoBasicExceptionRuleTest extends RuleTestCase
+{
+    protected function getRule(): \PHPStan\Rules\Rule
+    {
+        return new NoBasicExceptionRule();
+    }
+
+    public function testRuleThrowsException(): void
+    {
+        $this->analyse([__DIR__ . '/data/NoBasicExceptionRule/BasicExceptionClass.php'], [
+            ["Basic exceptions are not allowed. Please create a custom Exception instead.", 8]
+        ]);
+    }
+
+    public function testRuleDoesNotThrowsException(): void
+    {
+        $this->analyse([__DIR__ . '/data/NoBasicExceptionRule/AdvancedExceptionClass.php'], []);
+    }
+}

tests/Rules/data/NoBasicExceptionRule/AdvancedExceptionClass.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace MartinSoenen\PHPStanRules\Tests\Rules\data\NoBasicExceptionRule;
+
+use MartinSoenen\PHPStanRules\Tests\Rules\data\FooException;
+
+class AdvancedExceptionClass
+{
+    public function doFoo() {
+        throw new FooException("Test exception");
+    }
+}

tests/Rules/data/NoBasicExceptionRule/BasicExceptionClass.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace MartinSoenen\PHPStanRules\Tests\Rules\data\NoBasicExceptionRule;
+
+class BasicExceptionClass
+{
+    public function doFoo() {
+        throw new \Exception("Test exception");
+    }
+}