Skip to content

Commit 6af219b

Browse files
committed
fixed linting and tests
1 parent 742ffb5 commit 6af219b

6 files changed

Lines changed: 162 additions & 128 deletions

File tree

maseval/core/model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ class ChatResponse:
100100
content: Optional[str] = None
101101
tool_calls: Optional[List[Dict[str, Any]]] = None
102102
role: str = "assistant"
103-
usage: Optional[Dict[str, int]] = None
103+
usage: Optional[Dict[str, Any]] = None
104104
model: Optional[str] = None
105105
stop_reason: Optional[str] = None
106106

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def __init__(
4848
model_id: str = "test-model",
4949
responses: Optional[List[Optional[str]]] = None,
5050
tool_calls: Optional[List[Optional[List[Dict[str, Any]]]]] = None,
51-
usage: Optional[Dict[str, int]] = None,
51+
usage: Optional[Dict[str, Any]] = None,
5252
stop_reason: Optional[str] = None,
5353
seed: Optional[int] = None,
5454
):

tests/test_core/test_benchmark/test_usage_collection.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
import pytest
88
from maseval import TaskQueue
9-
from maseval.core.usage import StaticPricingCalculator
109

1110

1211
@pytest.mark.core
@@ -71,10 +70,12 @@ def test_usage_persists_across_task_repetitions(self):
7170
"""Benchmark.usage accumulates across multiple tasks."""
7271
from conftest import DummyBenchmark
7372

74-
tasks = TaskQueue.from_list([
75-
{"query": "Task 1", "environment_data": {}},
76-
{"query": "Task 2", "environment_data": {}},
77-
])
73+
tasks = TaskQueue.from_list(
74+
[
75+
{"query": "Task 1", "environment_data": {}},
76+
{"query": "Task 2", "environment_data": {}},
77+
]
78+
)
7879
benchmark = DummyBenchmark()
7980
benchmark.run(tasks, agent_data={"model": "test"})
8081

tests/test_core/test_registry.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
from maseval.core.registry import ComponentRegistry
1414
from maseval.core.tracing import TraceableMixin
1515
from maseval.core.config import ConfigurableMixin
16+
from maseval.core.usage import UsageTrackableMixin
1617

1718

1819
# ==================== Test Components ====================
@@ -276,6 +277,7 @@ def gather_traces(self) -> Dict[str, Any]:
276277

277278
def gather_usage(self):
278279
from maseval.core.usage import TokenUsage
280+
279281
return TokenUsage(
280282
cost=self._cost,
281283
input_tokens=self._input_tokens,
@@ -297,10 +299,6 @@ def gather_usage(self):
297299
raise RuntimeError("Usage collection failed")
298300

299301

300-
# Ensure MockUsageComponent also inherits UsageTrackableMixin
301-
from maseval.core.usage import UsageTrackableMixin
302-
303-
304302
class UsageAwareComponent(TraceableMixin, UsageTrackableMixin):
305303
"""Component with both tracing and usage tracking."""
306304

@@ -315,6 +313,7 @@ def gather_traces(self) -> Dict[str, Any]:
315313

316314
def gather_usage(self):
317315
from maseval.core.usage import TokenUsage
316+
318317
return TokenUsage(
319318
cost=self._cost,
320319
input_tokens=self._input_tokens,
@@ -362,7 +361,6 @@ def test_non_usage_component_not_in_usage_registry(self):
362361

363362
def test_collect_usage_basic(self):
364363
"""collect_usage returns structured dict with usage from registered components."""
365-
from maseval.core.usage import TokenUsage
366364

367365
registry = ComponentRegistry()
368366
model = UsageAwareComponent(cost=0.10, input_tokens=500, output_tokens=200)
@@ -445,7 +443,10 @@ def test_usage_by_component_accumulates(self):
445443
by_comp = registry.usage_by_component
446444
assert "models:main_model" in by_comp
447445

446+
from maseval.core.usage import TokenUsage
447+
448448
total = by_comp["models:main_model"]
449+
assert isinstance(total, TokenUsage)
449450
assert total.input_tokens == 300
450451
assert total.output_tokens == 150
451452
assert total.cost == pytest.approx(0.30)

0 commit comments

Comments
 (0)