Skip to content

Improvement of Non-Seeding Workflow#27

Merged
cemde merged 4 commits into
mainfrom
cleanup-seeding
Feb 4, 2026
Merged

Improvement of Non-Seeding Workflow#27
cemde merged 4 commits into
mainfrom
cleanup-seeding

Conversation

@cemde

@cemde cemde commented Feb 4, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Simplified the seeding API by making seed_generator always non-None in setup methods
  • When seeding is disabled (seed=None), derive_seed() returns None instead of the generator being None
  • Eliminates all if seed_generator is not None: conditional checks throughout the codebase - the same code path works whether seeding is enabled or disabled

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement (refactoring, formatting, etc.)

Checklist

Contribution

Documentation

  • Added/updated docstrings for new/modified functions as instructed CONTRIBUTING.md
  • Updated relevant documentation in docs/ (if applicable)
  • Tag github issue with this PR (if applicable)

Changelog

  • Added entry to CHANGELOG.md under [Unreleased] section
    • Use Added section for new features
    • Use Changed section for modifications to existing functionality
    • Use Fixed section for bug fixes
    • Use Removed section for deprecated/removed features
  • OR this is a documentation-only change (no changelog needed)

Example:
- Support for multi-agent tracing (PR:#123)

Architecture (if applicable)

  • Core/Interface separation: Changes in maseval/core/ do NOT import from maseval/interface/
  • Dependencies: New core dependencies added sparingly; framework integrations go to optional dependencies

Additional Notes

@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  maseval/benchmark/gaia2
  gaia2.py
  maseval/benchmark/macs
  macs.py
  maseval/benchmark/multiagentbench
  multiagentbench.py
  maseval/benchmark/tau2
  tau2.py
  maseval/core
  benchmark.py
  seeding.py
Project Total  

This report was generated by python-coverage-comment-action

@cemde cemde marked this pull request as ready for review February 4, 2026 17:52
@cemde cemde merged commit e5ec08d into main Feb 4, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant