Skip to content

fix: opam update before lsp upgrade#1650

Closed
mercxry wants to merge 1 commit into
mason-org:mainfrom
mercxry:fix/opam-update-before-lsp-upgrade
Closed

fix: opam update before lsp upgrade#1650
mercxry wants to merge 1 commit into
mason-org:mainfrom
mercxry:fix/opam-update-before-lsp-upgrade

Conversation

@mercxry
Copy link
Copy Markdown

@mercxry mercxry commented Mar 14, 2024

Hello 👋

I'm fixing a bug where installing a new version of ocaml-lsp would make opam complain about not being able to find the new version locally, this is because opam update needs to be run first to update the local repositories, so I'm running that command before any installation.

Copy link
Copy Markdown
Member

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ⭐!

@williamboman
Copy link
Copy Markdown
Member

@williambotman /fixup

@williamboman
Copy link
Copy Markdown
Member

Ugh stylua is complaining, I'll fix it shortly.

I just saw the following in their docs which I don't understand, but which might be a bit problematic if it can't be turned off. Will have to research it a bit more

It will also update any packages that are bound to version-controlled sources.

@williamboman
Copy link
Copy Markdown
Member

Hi again, I've not been able to find a resolution to the concern above of this command potentially modifying opam packages installed elsewhere on the system. One of the core principles of mason.nvim is to never touch the file system outside of Mason's root directory (except logs, cache, etc. that dependencies write). I'll go ahead and close this for now but I'd be open if we can resolve it somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants