fix(powershell) convert "Stop" to 'Stop' and a join parameter to single quotes#1740
Merged
Merged
Conversation
2 tasks
thomastan
force-pushed
the
fix-powershell-quotes
branch
from
d720934 to
8d1a462
Compare
williamboman
force-pushed
the
fix-powershell-quotes
branch
from
3094216 to
00fc593
Compare
williamboman
approved these changes
Apr 21, 2026
Member
williamboman
left a comment
williamboman
left a comment
There was a problem hiding this comment.
Thanks! I spent quite a lot of time trying to debug this but were unable to actually confirm whether the quotation marks are the root cause. I believe there's something else going on, but I guess it doesn't hurt to use single quotes everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes http://github.com/williamboman/mason.nvim/issues/1739
A single-quote was needed to pass the 'Stop' through to
powershell/pwshcorrectly.'SilentlyContinue' was single-quoted while "Stop" was double-quoted. Converting "Stop" → 'Stop'.