fix: reload notes and math after vault path change

Author: antonreshetov

src/renderer/components/preferences/Storage.vue

@@ -2,14 +2,28 @@
 import type { DialogOptions } from '~/main/types/ipc'
 import type { SnippetsCountsResponse } from '~/renderer/services/api/generated'
 import { Button } from '@/components/ui/shadcn/button'
-import { useDialog, useFolders, useSnippets, useSonner } from '@/composables'
+import {
+  resetNotesSpaceInitialization,
+  useDialog,
+  useFolders,
+  useMathNotebook,
+  useNoteFolders,
+  useNotes,
+  useNoteTags,
+  useSnippets,
+  useSonner,
+} from '@/composables'
 import { i18n, ipc, store } from '@/electron'
 import { LoaderCircle } from 'lucide-vue-next'
 import { api } from '~/renderer/services/api'
 
 const { sonner } = useSonner()
 const { confirm } = useDialog()
 const { getFolders } = useFolders()
+const { reset: resetMathNotebook } = useMathNotebook()
+const { resetNoteFoldersState } = useNoteFolders()
+const { clearNotesState } = useNotes()
+const { resetNoteTags } = useNoteTags()
 const { getSnippets } = useSnippets()
 
 function getDefaultVaultPath(baseStoragePath: string): string {
@@ -89,6 +103,11 @@ async function openVaultStorage() {
 
   vaultPath.value = result
   store.preferences.set('storage.vaultPath', result)
+  resetMathNotebook()
+  clearNotesState()
+  resetNoteFoldersState()
+  resetNoteTags()
+  resetNotesSpaceInitialization()
 
   await nextTick()
 

src/renderer/composables/__tests__/useMathNotebook.test.ts

@@ -0,0 +1,46 @@
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { computed, ref } from 'vue'
+
+const invoke = vi.fn()
+
+globalThis.ref = ref
+globalThis.computed = computed
+
+vi.mock('@/electron', () => ({
+  i18n: {
+    t: (key: string) => key,
+  },
+  ipc: {
+    invoke,
+  },
+}))
+
+vi.mock('@/composables/useStorageMutation', () => ({
+  markPersistedStorageMutation: vi.fn(),
+}))
+
+describe('useMathNotebook', () => {
+  beforeEach(() => {
+    vi.resetModules()
+    vi.clearAllMocks()
+    invoke.mockResolvedValue({
+      sheets: [],
+      activeSheetId: null,
+    })
+  })
+
+  it('loads again after reset', async () => {
+    const { useMathNotebook } = await import(
+      '../math-notebook/useMathNotebook'
+    )
+    const notebook = useMathNotebook()
+
+    await notebook.init()
+    expect(invoke).toHaveBeenCalledTimes(1)
+
+    notebook.reset()
+    await notebook.init()
+
+    expect(invoke).toHaveBeenCalledTimes(2)
+  })
+})

src/renderer/composables/math-notebook/useMathNotebook.ts

@@ -56,6 +56,12 @@ async function loadFromDisk() {
   activeSheetId.value = data?.activeSheetId ?? null
 }
 
+function resetMathNotebook() {
+  sheets.value = []
+  activeSheetId.value = null
+  initialized = false
+}
+
 export function useMathNotebook() {
   async function init() {
     if (initialized) {
@@ -133,6 +139,7 @@ export function useMathNotebook() {
     activeSheet,
     init,
     reloadFromDisk,
+    reset: resetMathNotebook,
     createSheet,
     deleteSheet,
     updateSheet,

src/renderer/composables/spaces/notes/__tests__/useNotesSpaceInitialization.test.ts

@@ -130,4 +130,24 @@ describe('useNotesSpaceInitialization', () => {
     expect(context.getNotes).not.toHaveBeenCalled()
     expect(context.getNoteTags).not.toHaveBeenCalled()
   })
+
+  it('loads again after initialization state reset', async () => {
+    const context = await setup({
+      isInitialized: true,
+      noteId: 1,
+      displayedNoteIds: [1, 2, 3],
+    })
+
+    const { resetNotesSpaceInitialization } = await import(
+      '../useNotesSpaceInitialization'
+    )
+
+    resetNotesSpaceInitialization()
+    await context.initNotesSpace()
+
+    expect(context.getNoteFolders).toHaveBeenCalledTimes(1)
+    expect(context.getNotes).toHaveBeenCalledTimes(1)
+    expect(context.getNoteTags).toHaveBeenCalledTimes(1)
+    expect(context.isNotesSpaceInitialized.value).toBe(true)
+  })
 })

src/renderer/composables/spaces/notes/index.ts

@@ -5,6 +5,9 @@ export { useNoteFolderTree } from './useNoteFolderTree'
 export { useNotes } from './useNotes'
 export { useNotesApp } from './useNotesApp'
 export { useNoteSearch } from './useNoteSearch'
-export { useNotesSpaceInitialization } from './useNotesSpaceInitialization'
+export {
+  resetNotesSpaceInitialization,
+  useNotesSpaceInitialization,
+} from './useNotesSpaceInitialization'
 export { useNoteTags } from './useNoteTags'
 export { useNoteUpdate } from './useNoteUpdate'

src/renderer/composables/spaces/notes/useNoteFolders.ts

@@ -168,6 +168,12 @@ function clearFolderSelection() {
   lastSelectedFolderId.value = undefined
 }
 
+function resetNoteFoldersState() {
+  folders.value = []
+  renameFolderId.value = null
+  clearFolderSelection()
+}
+
 function setFolderSelection(ids: number[]) {
   if (!ids.length) {
     clearFolderSelection()
@@ -409,6 +415,7 @@ export function useNoteFolders() {
     getNoteFolders,
     lastSelectedFolderId,
     renameFolderId,
+    resetNoteFoldersState,
     selectedFolderIds,
     selectNoteFolder,
     setFolderSelection,

src/renderer/composables/spaces/notes/useNoteTags.ts

@@ -59,12 +59,17 @@ async function deleteNoteTag(tagId: number) {
   }
 }
 
+function resetNoteTags() {
+  tags.value = []
+}
+
 export function useNoteTags() {
   return {
     addNoteTag,
     deleteNoteTag,
     getNoteTags,
     isLoading,
+    resetNoteTags,
     tags,
     updateNoteTag,
   }

src/renderer/composables/spaces/notes/useNotesSpaceInitialization.ts

@@ -15,6 +15,10 @@ const { getNotes, selectFirstNote } = useNotes()
 const { displayedNotes } = useNoteSearch()
 const { getNoteTags } = useNoteTags()
 
+export function resetNotesSpaceInitialization() {
+  isNotesSpaceInitialized.value = false
+}
+
 function hasSelectedNoteInList(noteId: number | undefined): boolean {
   if (noteId === undefined || !displayedNotes.value?.length) {
     return false