chore: hardening and cleanup pass

- Drop .env from Dockerfile, inject via docker-compose env_file, add
  .env.example, bind Fastify/ports to 127.0.0.1
- Fastify bodyLimit 1KB, requestTimeout 15s, setErrorHandler, empty-body
  JSON schemas on all POST routes
- Shared axios client with 15s timeout (src/services/http.ts)
- Type route handlers with FastifyInstance/Request/Reply; await Telegram
  sends in try/catch; move "D1" to config.alert_zone
- Add UNIQUE (report_number) migration and PostgreSQL.createOrIgnore
  (ON CONFLICT DO NOTHING RETURNING) to prevent duplicate alert inserts
- Replace system cron + curl loop with in-process croner scheduler and
  extract task bodies into src/tasks/; Dockerfile drops cron package,
  cron.txt, log-dir setup, shell-chained CMD
- Graceful shutdown on SIGTERM/SIGINT: stopScheduler -> fastify.close ->
  database.stop with 10s hard-exit guard
- postgresql.ts: pino logger instead of console.log, flatten query()
  control flow, drop JSON.parse(JSON.stringify), preserve error stack,
  remove duplicate table-name alias in UPDATE
- Fix filename id parsing to replace all underscores with slashes
- Fix .mocharc.json spec path and rename src/utilites -> src/utilities

Author: nicomontanari

.env.example

@@ -0,0 +1,11 @@
+TELEGRAM_TOKEN=
+TELEGRAM_2_TOKEN=
+CHAT_ID=
+CHANNEL_ID=
+DATABASE_NAME=
+DATABASE_HOST=
+DATABASE_PROD_HOST=
+DATABASE_PORT=
+DATABASE_USERNAME=
+DATABASE_PASSWORD=
+ALERT_ZONE=D1

.mocharc.json

@@ -1,5 +1,5 @@
 {
     "require": ["ts-node/register"],
     "extension": ["ts"],
-    "spec": "./test/**/*.ts"
+    "spec": "./tests/**/*.ts"
 }

Dockerfile

@@ -1,36 +1,19 @@
 FROM node:22.15.0
 WORKDIR /usr/app
 
-# Install system dependencies including cron
 RUN apt-get update && apt-get install -y \
     curl \
-    cron \
     && rm -rf /var/lib/apt/lists/*
 
 COPY package.json yarn.lock tsconfig.json ./
 RUN yarn install --frozen-lockfile
 
 COPY ./src ./src
-COPY cron.txt /etc/cron.d/mida-cron
-COPY .env ./
 
 RUN yarn dist
 
-# Set up cron job from file
-RUN chmod 0644 /etc/cron.d/mida-cron
-RUN echo "" >> /etc/cron.d/mida-cron
-RUN crontab -r || true
-RUN crontab /etc/cron.d/mida-cron
-
-# Create log directory for cron
-RUN mkdir -p /var/log/cron
-RUN touch /var/log/cron/meteo_alerts.log
-RUN touch /var/log/cron/check_pretemp_report.log
-RUN touch /var/log/cron/check_estofex_report.log
-
 EXPOSE 3000
 
 ENV NODE_ENV production
 
-# Start cron service and the main application
-CMD ["sh", "-c", "cron && node ./dist/src/index.js"]
+CMD ["node", "./dist/src/index.js"]

README.md

@@ -43,11 +43,20 @@ The application relies on scheduled tasks (crons) to automate the weather monito
 
 ### Environment Variables (`.env`)
 
-The project uses a `.env` file for configuration. Required keys include:
+The project uses a `.env` file for configuration. Copy `.env.example` to `.env` and fill in the values:
+
+```bash
+cp .env.example .env
+```
+
+Required keys include:
 
 - PostgreSQL Database credentials (Host, User, Password, DB Name)
 - `TELEGRAM_TOKEN`: Telegram Bot token.
 - `CHAT_ID`: ID of the Telegram chat or channel where alerts will be sent.
+- `ALERT_ZONE`: alert zone code to monitor (default `D1`).
+
+The `.env` file is git-ignored and is injected into the container at runtime via `docker-compose.yml` (`env_file`). It is **not** baked into the Docker image. If credentials leak, rotate the Telegram bot token via [@BotFather](https://t.me/BotFather) and reset the PostgreSQL password.
 
 ### Development Setup
 

cron.txt

@@ -5,7 +5,9 @@ services:
             context: .
             dockerfile: Dockerfile
         ports:
-            - '3000:3000'
+            - '127.0.0.1:3000:3000'
+        env_file:
+            - .env
         restart: unless-stopped
         extra_hosts:
             - "host.docker.internal:host-gateway"

docker-compose.yml

@@ -0,0 +1,11 @@
+-- Prevent duplicate alert_reports rows when concurrent scheduler ticks
+-- or manual route invocations race on the same report_number.
+-- Apply manually on production after deduping existing rows, e.g.:
+--
+--   DELETE FROM alert_reports a
+--   USING alert_reports b
+--   WHERE a.id < b.id
+--     AND a.report_number = b.report_number;
+--
+ALTER TABLE alert_reports
+    ADD CONSTRAINT alert_reports_report_number_key UNIQUE (report_number);

migrations/001_alert_reports_unique_report_number.sql

@@ -11,6 +11,7 @@
   },
   "dependencies": {
     "axios": "^1.10.0",
+    "croner": "^10.0.1",
     "dotenv": "^17.2.0",
     "fast-xml-parser": "^5.2.5",
     "fastify": "^5.4.0",

package.json

@@ -11,6 +11,7 @@ export interface Config {
     database: DatabaseConfig
     telegram_token: string
     chat_id: string
+    alert_zone: string
 }
 
 export const getNodeEnv = (): NodeEnv => process.env.NODE_ENV as NodeEnv

src/config/config.ts

@@ -13,4 +13,5 @@ export const developmentConfig: Config = {
     },
     telegram_token: process.env.TELEGRAM_2_TOKEN as string,
     chat_id: process.env.CHAT_ID as string,
+    alert_zone: process.env.ALERT_ZONE || 'D1',
 }