This repository was archived by the owner on Jun 26, 2018. It is now read-only.
Dp 8266 print styles for guides -- Do Not Merge#818
Closed
isaacchansky wants to merge 24 commits intodevfrom
Closed
Dp 8266 print styles for guides -- Do Not Merge#818isaacchansky wants to merge 24 commits intodevfrom
isaacchansky wants to merge 24 commits intodevfrom
Conversation
clair0917
changed the title
Contributor
|
Closing this PR in favor of the more recent updates found here: massgov/mayflower#862 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A New PR has been included with the PR found here: massgov/mayflower#862
This PR should not be merged
Description
This PR cleans up and organizes a bunch of print CSS for Mayflower. This is a work in progress but this is a first pass at an overhaul to cover the majority of the more egregious components.
Related Issue / Ticket
Steps to Test
esckey) using the menu within that drawer, open the rendering tab, then select print rendering from the bottom dropdown in that list. This is confusing to find... so see attached gif for reference!Screenshots
Use something like licecap to capture gifs to demonstrate behaviors.
Additional Notes:
Anything else to add?
Impacted Areas in Application
_print.scss@todo
Action finders specifically are kind of gross and should have a unique print treatment I think - though I believe they are passable for now.
We may want to consider saving ink and avoiding having colored backgrounds wherever possible.