Skip to content

Commit 64ceaad

Browse files
committed
Fix proto deserialization: add enable_exact_reverse_scan default
1 parent fdfa2c7 commit 64ceaad

3 files changed

Lines changed: 5 additions & 0 deletions

File tree

datafusion/common/src/file_options/parquet_writer.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -465,6 +465,7 @@ mod tests {
465465
skip_arrow_metadata: defaults.skip_arrow_metadata,
466466
coerce_int96: None,
467467
max_predicate_cache_size: defaults.max_predicate_cache_size,
468+
enable_exact_reverse_scan: defaults.enable_exact_reverse_scan,
468469
}
469470
}
470471

@@ -579,6 +580,8 @@ mod tests {
579580
binary_as_string: global_options_defaults.binary_as_string,
580581
skip_arrow_metadata: global_options_defaults.skip_arrow_metadata,
581582
coerce_int96: None,
583+
enable_exact_reverse_scan: global_options_defaults
584+
.enable_exact_reverse_scan,
582585
},
583586
column_specific_options,
584587
key_value_metadata,

datafusion/proto-common/src/from_proto/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1013,6 +1013,7 @@ impl TryFrom<&protobuf::ParquetOptions> for ParquetOptions {
10131013
max_predicate_cache_size: value.max_predicate_cache_size_opt.map(|opt| match opt {
10141014
protobuf::parquet_options::MaxPredicateCacheSizeOpt::MaxPredicateCacheSize(v) => Some(v as usize),
10151015
}).unwrap_or(None),
1016+
enable_exact_reverse_scan: false,
10161017
})
10171018
}
10181019
}

datafusion/proto/src/logical_plan/file_formats.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,7 @@ mod parquet {
525525
max_predicate_cache_size: proto.max_predicate_cache_size_opt.as_ref().map(|opt| match opt {
526526
parquet_options::MaxPredicateCacheSizeOpt::MaxPredicateCacheSize(size) => *size as usize,
527527
}),
528+
enable_exact_reverse_scan: false,
528529
}
529530
}
530531
}

0 commit comments

Comments
 (0)