comment tests

Author: xudong963

datafusion/core/tests/parquet/mod.rs

@@ -150,11 +150,18 @@ impl TestOutput {
         self.metric_value("row_groups_matched_statistics")
     }
 
+    /*
     /// The number of row_groups fully matched by statistics
     fn row_groups_fully_matched_statistics(&self) -> Option<usize> {
         self.metric_value("row_groups_fully_matched_statistics")
     }
 
+    /// The number of row groups pruned by limit pruning
+    fn limit_pruned_row_groups(&self) -> Option<usize> {
+        self.metric_value("limit_pruned_row_groups")
+    }
+    */
+
     /// The number of row_groups pruned by statistics
     fn row_groups_pruned_statistics(&self) -> Option<usize> {
         self.metric_value("row_groups_pruned_statistics")
@@ -183,11 +190,6 @@ impl TestOutput {
         self.metric_value("page_index_rows_pruned")
     }
 
-    /// The number of row groups pruned by limit pruning
-    fn limit_pruned_row_groups(&self) -> Option<usize> {
-        self.metric_value("limit_pruned_row_groups")
-    }
-
     fn description(&self) -> String {
         format!(
             "Input:\n{}\nQuery:\n{}\nOutput:\n{}\nMetrics:\n{}",
@@ -204,7 +206,8 @@ impl ContextWithParquet {
         Self::with_config(scenario, unit, SessionConfig::new(), None, None).await
     }
 
-    /// Set custom schema and batches for the test
+    // Set custom schema and batches for the test
+    /*
     pub async fn with_custom_data(
         scenario: Scenario,
         unit: Unit,
@@ -220,6 +223,7 @@ impl ContextWithParquet {
         )
         .await
     }
+    */
 
     async fn with_config(
         scenario: Scenario,

datafusion/core/tests/parquet/row_group_pruning.rs

@@ -18,12 +18,8 @@
 //! This file contains an end to end test of parquet pruning. It writes
 //! data into a parquet file and then verifies row groups are pruned as
 //! expected.
-use std::sync::Arc;
-
-use arrow::array::{ArrayRef, Int32Array, RecordBatch};
-use arrow_schema::{DataType, Field, Schema};
 use datafusion::prelude::SessionConfig;
-use datafusion_common::{DataFusionError, ScalarValue};
+use datafusion_common::ScalarValue;
 use itertools::Itertools;
 
 use crate::parquet::Unit::RowGroup;
@@ -34,12 +30,12 @@ struct RowGroupPruningTest {
     query: String,
     expected_errors: Option<usize>,
     expected_row_group_matched_by_statistics: Option<usize>,
-    expected_row_group_fully_matched_by_statistics: Option<usize>,
+    // expected_row_group_fully_matched_by_statistics: Option<usize>,
     expected_row_group_pruned_by_statistics: Option<usize>,
     expected_files_pruned_by_statistics: Option<usize>,
     expected_row_group_matched_by_bloom_filter: Option<usize>,
     expected_row_group_pruned_by_bloom_filter: Option<usize>,
-    expected_limit_pruned_row_groups: Option<usize>,
+    // expected_limit_pruned_row_groups: Option<usize>,
     expected_rows: usize,
 }
 impl RowGroupPruningTest {
@@ -51,11 +47,11 @@ impl RowGroupPruningTest {
             expected_errors: None,
             expected_row_group_matched_by_statistics: None,
             expected_row_group_pruned_by_statistics: None,
-            expected_row_group_fully_matched_by_statistics: None,
+            // expected_row_group_fully_matched_by_statistics: None,
             expected_files_pruned_by_statistics: None,
             expected_row_group_matched_by_bloom_filter: None,
             expected_row_group_pruned_by_bloom_filter: None,
-            expected_limit_pruned_row_groups: None,
+            // expected_limit_pruned_row_groups: None,
             expected_rows: 0,
         }
     }
@@ -85,6 +81,7 @@ impl RowGroupPruningTest {
     }
 
     // Set the expected fully matched row groups by statistics
+    /*
     fn with_fully_matched_by_stats(
         mut self,
         fully_matched_by_stats: Option<usize>,
@@ -93,6 +90,12 @@ impl RowGroupPruningTest {
         self
     }
 
+    fn with_limit_pruned_row_groups(mut self, pruned_by_limit: Option<usize>) -> Self {
+        self.expected_limit_pruned_row_groups = pruned_by_limit;
+        self
+    }
+    */
+
     // Set the expected pruned row groups by statistics
     fn with_pruned_by_stats(mut self, pruned_by_stats: Option<usize>) -> Self {
         self.expected_row_group_pruned_by_statistics = pruned_by_stats;
@@ -116,11 +119,6 @@ impl RowGroupPruningTest {
         self
     }
 
-    fn with_limit_pruned_row_groups(mut self, pruned_by_limit: Option<usize>) -> Self {
-        self.expected_limit_pruned_row_groups = pruned_by_limit;
-        self
-    }
-
     /// Set the number of expected rows from the output of this test
     fn with_expected_rows(mut self, rows: usize) -> Self {
         self.expected_rows = rows;
@@ -177,6 +175,7 @@ impl RowGroupPruningTest {
     }
 
     // Execute the test with the current configuration
+    /*
     async fn test_row_group_prune_with_custom_data(
         self,
         schema: Arc<Schema>,
@@ -233,6 +232,7 @@ impl RowGroupPruningTest {
             output.description(),
         );
     }
+    */
 }
 
 #[tokio::test]
@@ -1721,6 +1721,7 @@ async fn test_bloom_filter_decimal_dict() {
         .await;
 }
 
+/*
 // Helper function to create a batch with a single Int32 column.
 fn make_i32_batch(
     name: &str,
@@ -1958,3 +1959,4 @@ async fn test_limit_pruning_exceeds_fully_matched() -> datafusion_common::error:
 
     Ok(())
 }
+*/