🧪 [testing improvement] Missing test for compiled objects (proto.preOps)

test/compiled_objects.test.js

@@ -0,0 +1,272 @@
+const { autoAssignActions } = require('../index')
+
+describe('Compiled Objects and Edge Cases', () => {
+  let originalDataform
+
+  beforeEach(() => {
+    // Save original global state
+    originalDataform = global.dataform
+
+    // Reset global state
+    global.dataform = {
+      actions: [],
+      projectConfig: {
+        defaultDatabase: 'test-project',
+        defaultSchema: 'test-schema'
+      }
+    }
+  })
+
+  afterEach(() => {
+    // Restore original global state
+    global.dataform = originalDataform
+  })
+
+  const config = [
+    {
+      tag: 'test',
+      reservation: 'projects/test/locations/US/reservations/prod',
+      actions: ['test-project.test-schema.target_action']
+    }
+  ]
+
+  test('should apply reservation to compiled object via proto.preOps (array)', () => {
+    const action = {
+      type: 'table',
+      target: {
+        database: 'test-project',
+        schema: 'test-schema',
+        name: 'target_action'
+      },
+      preOps: [] // This will be treated as proto.preOps because action.proto is undefined
+    }
+    global.dataform.actions.push(action)
+
+    autoAssignActions(config)
+
+    expect(action.preOps).toContain('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+  })
+
+  test('should initialize proto.preOps if it does not exist', () => {
+    const action = {
+      type: 'table',
+      target: {
+        database: 'test-project',
+        schema: 'test-schema',
+        name: 'target_action'
+      }
+      // preOps is missing
+    }
+    global.dataform.actions.push(action)
+
+    autoAssignActions(config)
+
+    expect(action.preOps).toBeDefined()
+    expect(Array.isArray(action.preOps)).toBe(true)
+    expect(action.preOps).toContain('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+  })
+
+  test('should handle proto.preOps as a string', () => {
+    const action = {
+      type: 'table',
+      target: {
+        database: 'test-project',
+        schema: 'test-schema',
+        name: 'target_action'
+      },
+      preOps: 'SELECT 1;'
+    }
+    global.dataform.actions.push(action)
+
+    autoAssignActions(config)
+
+    expect(Array.isArray(action.preOps)).toBe(true)
+    expect(action.preOps[0]).toBe('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+    expect(action.preOps[1]).toBe('SELECT 1;')
+  })
+
+  test('should apply reservation to compiled operation via proto.queries (array)', () => {
+    const action = {
+      queries: ['SELECT * FROM table'],
+      target: {
+        database: 'test-project',
+        schema: 'test-schema',
+        name: 'target_action'
+      }
+    }
+    global.dataform.actions.push(action)
+
+    autoAssignActions(config)
+
+    expect(action.queries).toContain('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+    expect(action.queries[0]).toBe('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+  })
+
+  test('should handle proto.queries as a string', () => {
+    const action = {
+      queries: 'SELECT * FROM table',
+      target: {
+        database: 'test-project',
+        schema: 'test-schema',
+        name: 'target_action'
+      }
+    }
+    global.dataform.actions.push(action)
+
+    autoAssignActions(config)
+
+    expect(Array.isArray(action.queries)).toBe(true)
+    expect(action.queries[0]).toBe('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+    expect(action.queries[1]).toBe('SELECT * FROM table')
+  })
+
+  test('should fallback to action.preOps() function if hasType is true but proto.preOps is not an array/string', () => {
+    const preOpsMock = jest.fn()
+    const action = {
+      type: 'table',
+      target: {
+        database: 'test-project',
+        schema: 'test-schema',
+        name: 'target_action'
+      },
+      preOps: preOpsMock // This is a function
+    }
+    global.dataform.actions.push(action)
+
+    autoAssignActions(config)
+
+    expect(preOpsMock).toHaveBeenCalledWith('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+  })
+
+  test('should fallback to action.preOps() function if no other method matches (Fallback 5)', () => {
+    const preOpsMock = jest.fn()
+    const action = {
+      // No type, no queries, no contextable fields
+      target: {
+        database: 'test-project',
+        schema: 'test-schema',
+        name: 'target_action'
+      },
+      preOps: preOpsMock
+    }
+    global.dataform.actions.push(action)
+
+    autoAssignActions(config)
+
+    expect(preOpsMock).toHaveBeenCalledWith('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+  })
+
+  test('should handle contextableQueries as a string', () => {
+    const action = {
+      contextableQueries: 'SELECT 1',
+      target: {
+        database: 'test-project',
+        schema: 'test-schema',
+        name: 'target_action'
+      }
+    }
+    global.dataform.actions.push(action)
+
+    autoAssignActions(config)
+
+    expect(Array.isArray(action.contextableQueries)).toBe(true)
+    expect(action.contextableQueries[0]).toBe('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+  })
+
+  test('should handle contextablePreOps as a string', () => {
+    const action = {
+      type: 'table',
+      contextablePreOps: 'SELECT 1',
+      target: {
+        database: 'test-project',
+        schema: 'test-schema',
+        name: 'target_action'
+      }
+    }
+    global.dataform.actions.push(action)
+
+    autoAssignActions(config)
+
+    expect(Array.isArray(action.contextablePreOps)).toBe(true)
+    expect(action.contextablePreOps[0]).toBe('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+  })
+
+  test.each([
+    {
+      name: 'function returning string',
+      input: () => 'SELECT 1',
+      validator: (result) => {
+        expect(result).toContain('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+        expect(result).toContain('SELECT 1')
+      }
+    },
+    {
+      name: 'function returning array',
+      input: () => ['SELECT 1', 'SELECT 2'],
+      validator: (result) => {
+        expect(result[0]).toBe('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+        expect(result).toHaveLength(3)
+      }
+    },
+    {
+      name: 'function returning other types',
+      input: () => null,
+      validator: (result) => {
+        expect(result).toBe(null)
+      }
+    },
+    {
+      name: 'array',
+      input: ['SELECT 1'],
+      validator: (result) => {
+        expect(result[0]).toBe('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+      }
+    }
+  ])('should handle monkeypatched queries with $name', ({ input, validator }) => {
+    const action = {
+      queries: function(q) { this.resolvedQueries = q; return this },
+      proto: {
+        queries: [],
+        target: { database: 'test-project', schema: 'test-schema', name: 'target_action' }
+      }
+    }
+    global.dataform.actions.push(action)
+
+    autoAssignActions(config)
+
+    action.queries(input)
+
+    // For arrays, `action.queries()` directly assigns resolvedQueries if not wrapped,
+    // but the monkeypatch will wrap them. We extract the resolved value for validation.
+    // If input is an array, it's wrapped and immediately modifies `resolvedQueries` via the original function.
+    // Our action mock just sets `this.resolvedQueries = q`.
+    // So if the patched function returns, it calls the original function.
+    // Let's resolve what to test:
+    if (typeof input === 'function') {
+      const wrappedFn = action.resolvedQueries
+      expect(typeof wrappedFn).toBe('function')
+      const result = wrappedFn({})
+      validator(result)
+    } else {
+      validator(action.resolvedQueries)
+    }
+  })
+
+  test('should intercept sqlxAction', () => {
+    const sqlxActionMock = jest.fn(() => {
+      global.dataform.actions.push({
+        type: 'table',
+        target: { database: 'test-project', schema: 'test-schema', name: 'target_action' },
+        preOps: []
+      })
+    })
+    global.dataform.sqlxAction = sqlxActionMock
+
+    autoAssignActions(config)
+
+    global.dataform.sqlxAction()
+
+    const action = global.dataform.actions[0]
+    expect(action.preOps).toContain('SET @@reservation=\'projects/test/locations/US/reservations/prod\';')
+  })
+})