Gh actions#1554
Conversation
mbkma
force-pushed
the
gh-actions
branch
2 times, most recently
from
1d8e436 to
ce7fd84
Compare
| if [ -f autogen.sh ]; then | ||
| infobegin "Configure (autotools)" | ||
| NOCONFIGURE=1 ./autogen.sh | ||
| ./configure --prefix=/usr --enable-compile-warnings=maximum || { |
There was a problem hiding this comment.
We should also test with --with-in-process-applets=all (I think in addition to --with-in-process-applets=none), since this is important for Wayland builds. Maybe we do this only for a single distro (e.g. ${OS} == "debian", since that's what @lukefromdc uses for Wayland development I think?)
|
|
||
| infobegin "Check (autotools)" | ||
| make -j ${CPUS} check || { | ||
| true |
There was a problem hiding this comment.
Does this swallow errors - I think we do this in all our repos anyway, but wondering if we're missing stuff because of the || true...
|
|
||
| NAME="mate-desktop" | ||
| TEMP_DIR=$(mktemp -d) | ||
| OS=$(cat /etc/os-release | grep ^ID | head -n 1 | awk -F= '{ print $2}') |
There was a problem hiding this comment.
the /etc/os-release file sets the variables directly, you should be able to change this to OS=$(source /etc/os-release && echo $ID), which may be a bit more robust
|
Correct-we need to know what happens in-procrss. I am on Debian Unstable here
|
| matrix: | ||
| container: | ||
| [ | ||
| "debian:testing", |
There was a problem hiding this comment.
Should we change this to "debian:unstable" since that's what @lukefromdc is using? This would likely (hopefully) solve the bad cert issue in GH Actions
3 participants
No description provided.