Fallback to default of required components, if wrong set by user

Empty values are still possible, to disable a component.
Required components are currently: windowmanager , filemanager , panel and dock.
Code refactor: move code to new function append_required_apps_add_component().
Fixes: #324

Author: 2387skju

mate-session/main.c

@@ -227,14 +227,68 @@ static void append_default_apps(GsmManager* manager, const char* default_session
 
 		if (app_path != NULL)
 		{
-			gsm_manager_add_autostart_app(manager, app_path, NULL);
+			gsm_manager_add_autostart_app (manager, app_path, NULL);
 			g_free(app_path);
 		}
 	}
 
 	g_strfreev (default_apps);
 }
 
+static void append_required_apps_add_component (GsmManager* manager, GSettings* settings_required_components, const char* component, gboolean is_recursive_call)
+{
+	char* default_provider;
+
+	default_provider = g_settings_get_string (settings_required_components, component);
+
+	g_debug ("main: %s looking for component: '%s'", component, default_provider);
+
+	if (default_provider != NULL)
+	{
+		char* app_path;
+
+		app_path = gsm_util_find_desktop_file_for_app_name (default_provider, NULL);
+
+		if (app_path != NULL)
+		{
+			gsm_manager_add_autostart_app (manager, app_path, component);
+		}
+		else
+		{
+			g_warning ("Unable to find provider '%s' of required component '%s'", default_provider, component);
+
+			if (default_provider[0] != '\0' && !is_recursive_call)
+			{
+				// possible reset component to default
+
+				const char *default_default_provider;
+				GVariant *schema_default;
+				schema_default = g_settings_get_default_value (settings_required_components, component);
+
+				if (schema_default != NULL)
+				{
+					default_default_provider = g_variant_get_string (schema_default, NULL);
+
+					if (default_default_provider[0] != '\0' && strcmp (default_default_provider, default_provider) != 0)
+					{
+						g_warning ("Reset required component '%s' to default", component);
+						g_settings_reset (settings_required_components, component);
+
+						append_required_apps_add_component (manager, settings_required_components, component, TRUE);
+					}
+
+					g_variant_unref (schema_default);
+				}
+			}
+
+		}
+
+		g_free (app_path);
+	}
+
+	g_free (default_provider);
+}
+
 static void append_required_apps(GsmManager* manager)
 {
 	gchar** required_components;
@@ -257,39 +311,11 @@ static void append_required_apps(GsmManager* manager)
 	{
 		for (i = 0; required_components[i]; i++)
 		{
-			char* default_provider;
-			const char* component;
-
 			if (IS_STRING_EMPTY((char*) required_components[i]))
 			{
 				continue;
 			}
-
-			component = required_components[i];
-
-			default_provider = g_settings_get_string (settings_required_components, component);
-
-			g_debug ("main: %s looking for component: '%s'", component, default_provider);
-
-			if (default_provider != NULL)
-			{
-				char* app_path;
-
-				app_path = gsm_util_find_desktop_file_for_app_name(default_provider, NULL);
-
-				if (app_path != NULL)
-				{
-					gsm_manager_add_autostart_app(manager, app_path, component);
-				}
-				else
-				{
-					g_warning("Unable to find provider '%s' of required component '%s'", default_provider, component);
-				}
-
-				g_free(app_path);
-			}
-
-			g_free(default_provider);
+			append_required_apps_add_component(manager, settings_required_components, required_components[i], FALSE);
 		}
 	}