Required components default fallback#326
Open
2387skju wants to merge 2 commits into
Open
Conversation
9a19da8 to
8f312ab
Compare
vkareh
requested changes
Mar 17, 2026
8f312ab to
da50b2e
Compare
vkareh
requested changes
Mar 19, 2026
Member
vkareh
left a comment
There was a problem hiding this comment.
There are some memory management issues, but this is moving in the right direction, thanks.
da50b2e to
d728bd9
Compare
Author
|
Thanks for helping :-) Changes:
Split code in a new function ? :A suggestion: This function implemented in Code: |
d728bd9 to
643bd6f
Compare
Member
|
@2387skju this looks a lot better, thanks! I think you have a good suggestion there with the function, it will make things easier to understand for sure. |
643bd6f to
4105b10
Compare
496df6f to
f9f03f8
Compare
vkareh
reviewed
May 4, 2026
Member
vkareh
left a comment
There was a problem hiding this comment.
This is looking great! Just some minor nitpicks before this is ready
feb8397 to
f9f03f8
Compare
Empty values are still possible, to disable a component. Required components are currently: windowmanager , filemanager , panel and dock. Code refactor: move code to new function append_required_apps_add_component(). Fixes: mate-desktop#324
f9f03f8 to
98da258
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset the
required componentsto default, if not found.After uninstall a component, a fallback is need: will fix #324
(( Required components are: dock, filemanager, panel, window manager. ))
Changes in file mate-session/main.c :
Reset will be done, in this case:
Additional just for the Windowmanager:
Changes in file data/mate-wm :
command) ,(both shortly tested with older Mate Version 1.26 on Debian 13. ; I'm new in C-Language)