before and after methods moved to TestBase

Author: Matécsa Dániel

points.yml

@@ -207,7 +207,7 @@ advanced:
     link: "https://www.selenium.dev/documentation/webdriver/browsers/"
 
   dockerized_execution:      # 4 pts | once
-    done: false
+    done: true
     description: "Run tests inside a Docker container (e.g. using docker-compose with Selenium Grid)"
     link: "https://www.selenium.dev/documentation/grid/getting_started/"
 

tests/mytests/src/test/java/tests/DependencyTest.java

@@ -1,18 +1,12 @@
 package tests;
 
-import org.openqa.selenium.chrome.*;
-import org.openqa.selenium.remote.RemoteWebDriver;
-import java.net.URL;
-import java.util.HashMap;
-import java.util.Map;
 import java.net.MalformedURLException;
 
 import org.testng.annotations.*;
 import org.testng.*;
 
 import pages.LoginPage;
 import pages.MainPage;
-import utils.ConfigReader;
 
 public class DependencyTest extends TestBase {
 
@@ -21,14 +15,7 @@ public class DependencyTest extends TestBase {
     @BeforeClass
     public void Setup() throws MalformedURLException
     {
-        final Map<String, Object> chromePrefs = new HashMap<>();
-        chromePrefs.put("profile.password_manager_leak_detection", false);
-
-        ChromeOptions options = new ChromeOptions();
-        options.setExperimentalOption("prefs", chromePrefs);
-
-        this.driver = new RemoteWebDriver(new URL(ConfigReader.get("selenium_url")), options);
-        this.driver.manage().window().maximize();
+        before();
     }
 
     @Test
@@ -53,9 +40,7 @@ public void logoutTest() {
 
     @AfterClass
     public void close() {
-        if (this.driver != null) {
-            this.driver.quit();
-        }
+        after();
     }
 
 }

tests/mytests/src/test/java/tests/TestBase.java

@@ -1,6 +1,13 @@
 package tests;
 
+import java.util.HashMap;
+
 import org.openqa.selenium.*;
+import org.openqa.selenium.chrome.*;
+import org.openqa.selenium.remote.RemoteWebDriver;
+import java.net.URL;
+import java.util.Map;
+import java.net.MalformedURLException;
 
 import pages.LoginPage;
 import utils.ConfigReader;
@@ -9,6 +16,23 @@ public class TestBase {
 
     protected WebDriver driver;
 
+    protected void before() throws MalformedURLException {
+        final Map<String, Object> chromePrefs = new HashMap<>();
+        chromePrefs.put("profile.password_manager_leak_detection", false);
+
+        ChromeOptions options = new ChromeOptions();
+        options.setExperimentalOption("prefs", chromePrefs);
+
+        this.driver = new RemoteWebDriver(new URL(ConfigReader.get("selenium_url")), options);
+        this.driver.manage().window().maximize();
+    }
+
+    protected void after() {
+        if (this.driver != null) {
+            this.driver.quit();
+        }
+    }
+
     protected LoginPage login(LoginPage loginPage) {
         loginPage = new LoginPage(this.driver, ConfigReader.get("moodle_url"));
 

…/src/test/java/tests/MySeleniumTest.java …sts/src/test/java/tests/WebsiteTest.javatests/mytests/src/test/java/tests/MySeleniumTest.java renamed to tests/mytests/src/test/java/tests/WebsiteTest.java tests/mytests/src/test/java/tests/MySeleniumTest.java renamed to tests/mytests/src/test/java/tests/WebsiteTest.java

@@ -1,11 +1,6 @@
 package tests;
 
 import org.openqa.selenium.*;
-import org.openqa.selenium.chrome.*;
-import org.openqa.selenium.remote.RemoteWebDriver;
-import java.net.URL;
-import java.util.HashMap;
-import java.util.Map;
 import java.util.List;
 import java.util.Random;
 import java.net.MalformedURLException;
@@ -14,24 +9,15 @@
 import org.testng.*;
 
 import pages.*;
-import utils.ConfigReader;
 
-public class MySeleniumTest extends TestBase {
+public class WebsiteTest extends TestBase {
 
     @BeforeMethod
     public void Setup() throws MalformedURLException
     {
-        final Map<String, Object> chromePrefs = new HashMap<>();
-        chromePrefs.put("profile.password_manager_leak_detection", false);
-
-        ChromeOptions options = new ChromeOptions();
-        options.setExperimentalOption("prefs", chromePrefs);
-
-        this.driver = new RemoteWebDriver(new URL(ConfigReader.get("selenium_url")), options);
-        this.driver.manage().window().maximize();
+        before();
     }
 
-
     @Test
     public void courseCreation() {
         LoginPage loginPage = null;
@@ -88,9 +74,7 @@ public void cookieHandling() {
 
     @AfterMethod
     public void close() {
-        if (this.driver != null) {
-            this.driver.quit();
-        }
+        after();
     }
 
 }