fix(dialog): control with name="method" no longer breaks submit#5781
Merged
copybara-service[bot] merged 1 commit intomaterial-components:mainfrom Mar 20, 2025
Pickachu:fix-form-method-in-dialog
Merged
fix(dialog): control with name="method" no longer breaks submit#5781copybara-service[bot] merged 1 commit intomaterial-components:mainfrom Pickachu:fix-form-method-in-dialog
copybara-service[bot] merged 1 commit intomaterial-components:mainfrom
Pickachu:fix-form-method-in-dialog
Conversation
…method See the issue for more information: #5777
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
asyncliz
changed the title
asyncliz
approved these changes
Mar 7, 2025
Collaborator
asyncliz
left a comment
asyncliz
left a comment
There was a problem hiding this comment.
Thanks for the fix! Can you take a look at the bot comment and sign the CLA?
Collaborator
|
@Pickachu friendly ping on signing the CLA so we can merge this PR :) |
Contributor
Author
|
Hello, sorry for the delay. Too much github notifications. CLA signed. |
copybara-service
bot
merged commit ff9ab97
into
material-components:main
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5777
md-dialog: handleSubmit fails with a as dialog form child