Skip to content

chore(tabs): change indicator symbol to private member #5825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 27, 2025
Merged

chore(tabs): change indicator symbol to private member #5825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions tabs/internal/tab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ import {ClassInfo, classMap} from 'lit/directives/class-map.js';
import {EASING} from '../../internal/motion/animation.js';
import {mixinFocusable} from '../../labs/behaviors/focusable.js';

/**
* Symbol for tabs to use to animate their indicators based off another tab's
* indicator.
*/
const INDICATOR = Symbol('indicator');

/**
* Symbol used by the tab bar to request a tab to animate its indicator from a
* previously selected tab.
Expand Down Expand Up @@ -74,7 +68,7 @@ export class Tab extends tabBaseClass {
*/
@property({type: Boolean, attribute: 'icon-only'}) iconOnly = false;

@query('.indicator') readonly [INDICATOR]!: HTMLElement | null;
@query('.indicator') private readonly indicator!: HTMLElement | null;
@state() protected fullWidthIndicator = false;
@queryAssignedNodes({flatten: true})
private readonly assignedDefaultNodes!: Node[];
Expand Down Expand Up @@ -145,16 +139,16 @@ export class Tab extends tabBaseClass {
}

[ANIMATE_INDICATOR](previousTab: Tab) {
if (!this[INDICATOR]) {
if (!this.indicator) {
return;
}

this[INDICATOR].getAnimations().forEach((a) => {
this.indicator.getAnimations().forEach((a) => {
a.cancel();
});
const frames = this.getKeyframes(previousTab);
if (frames !== null) {
this[INDICATOR].animate(frames, {
this.indicator.animate(frames, {
duration: 250,
easing: EASING.EMPHASIZED,
});
Expand All @@ -169,10 +163,10 @@ export class Tab extends tabBaseClass {

const from: Keyframe = {};
const fromRect =
previousTab[INDICATOR]?.getBoundingClientRect() ?? ({} as DOMRect);
previousTab.indicator?.getBoundingClientRect() ?? ({} as DOMRect);
const fromPos = fromRect.left;
const fromExtent = fromRect.width;
const toRect = this[INDICATOR]!.getBoundingClientRect();
const toRect = this.indicator!.getBoundingClientRect();
const toPos = toRect.left;
const toExtent = toRect.width;
const scale = fromExtent / toExtent;
Expand Down
Loading