fix(ripple): remove pointerdown contextmenu bounds check for Chrome#5834
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
fix(ripple): remove pointerdown contextmenu bounds check for Chrome#5834copybara-service[bot] wants to merge 0 commit intomainfrom
copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
cl/791432699
branch
2 times, most recently
from
f1ac2f0 to
9187aad
Compare
copybara-service
Bot
force-pushed
the
cl/791432699
branch
from
9187aad to
cd7512f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ripple): remove pointerdown contextmenu bounds check for Chrome
tl;dr; the bug this check was handling is no longer reproducible in Chrome, where a
pointerdownevent would be dispatched after the user closes thecontextmenu