Skip to content

fix(radio): move root assignment to mirror hostDisconnected #5845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 2 commits into from
Sep 8, 2025
Merged

fix(radio): move root assignment to mirror hostDisconnected #5845

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adb8d10
fix(radio): move root assignment to mirror hostDisconnected
austinw-fineart Sep 2, 2025
6010e52
fix(radio): also move sibling uncheck logic after root assignment
austinw-fineart Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion radio/internal/single-selection-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ export class SingleSelectionController implements ReactiveController {
constructor(private readonly host: SingleSelectionElement) {}

hostConnected() {
this.root = this.host.getRootNode() as ParentNode;
this.host.addEventListener('keydown', this.handleKeyDown);
this.host.addEventListener('focusin', this.handleFocusIn);
this.host.addEventListener('focusout', this.handleFocusOut);
Expand All @@ -90,6 +89,7 @@ export class SingleSelectionController implements ReactiveController {
// connected at the same time.
queueMicrotask(() => {
// Update for the newly added host.
this.root = this.host.getRootNode() as ParentNode;
Comment thread
austinw-fineart marked this conversation as resolved.
this.updateTabIndices();
});
}
Expand Down