fix(field): prevent NaN transforms when element is hidden#5860
Merged
copybara-service[bot] merged 1 commit intomaterial-components:mainfrom Oct 29, 2025
ejmurc:fix-nan-transforms-hidden-field
Merged
fix(field): prevent NaN transforms when element is hidden#5860copybara-service[bot] merged 1 commit intomaterial-components:mainfrom ejmurc:fix-nan-transforms-hidden-field
copybara-service[bot] merged 1 commit intomaterial-components:mainfrom
ejmurc:fix-nan-transforms-hidden-field
Conversation
Fixes #5815 When a field's display is set to none, getBoundingClientRect() returns zeros, causing division by zero in getLabelKeyframes(). This resulted in NaN values in transform strings. Added check to skip animation when label dimensions are zero.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
asyncliz
approved these changes
Oct 29, 2025
Collaborator
asyncliz
left a comment
asyncliz
left a comment
There was a problem hiding this comment.
Thank you for this fix!
copybara-service
bot
merged commit 8341594
into
material-components:main
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5815
When a field's display is set to none, getBoundingClientRect() returns
zeros, causing division by zero in getLabelKeyframes(). This resulted
in NaN values in transform strings and console errors.
Changes:
dimensions are zero
a hidden field
Testing:
Verified that the new test passes and existing tests continue to pass.