Skip to content

chore: relax type property of mixinFormSubmitter to string #5912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 12, 2026
+2 −2
Merged

chore: relax type property of mixinFormSubmitter to string #5912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions labs/behaviors/form-submitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export interface FormSubmitter {
* - reset: The element resets the form.
* - button: The element does nothing.
*/
type: FormSubmitterType;
type: string;

/**
* The HTML name to use in form submission. When combined with a `value`, the
Expand Down Expand Up @@ -77,7 +77,7 @@ export function mixinFormSubmitter<
T extends MixinBase<LitElement & WithElementInternals>,
>(base: T): MixinReturn<T, FormSubmitter> {
abstract class FormSubmitterElement extends base implements FormSubmitter {
@property() type: FormSubmitterType = 'submit';
@property() type = 'submit';
@property({reflect: true}) value = '';

// Name attribute must reflect synchronously for form integration.
Expand Down
Loading