Skip to content

Custom GroupRender for boolean don't work for false value. #926

Description

@brunohpg

Describe the bug

The custom groupRender (property of column) is not called when JS evaluate a cell value as false, like boolean value false or number value 0.

The problem is in:

The 'if' checks props.value. When props.value === false or props.value === 0 the result is false and groupRender is not called. I think is better use (props.value === undefined || props.value === null) or just props.value == null.

To Reproduce

Just create a groupRender for a column of type boolean and fill some cells with false value. Then group by this column.

column.groupRender = (value) => value ? 'yes' : 'no';

Expected behavior

Custom groupRender should be called and group render must render 'yes' and 'no'. But'll render 'yes' and -.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions