Skip to content

fix init_columns for deletion #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tschaume merged 1 commit into from
Aug 14, 2025
Merged

fix init_columns for deletion #1934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions mpcontribs-client/mpcontribs/client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,12 +1584,11 @@ def delete_contributions(self, query: Optional[dict] = None, timeout: int = -1):
if self.project:
query["project"] = self.project

cids = list(self.get_all_ids(query).get(query["project"], {}).get("ids", set()))
name = query["project"]
cids = list(self.get_all_ids(query).get(name, {}).get("ids", set()))

if not cids:
logger.info(
f"There aren't any contributions to delete for {query['project']}"
)
logger.info(f"There aren't any contributions to delete for {name}")
return

total = len(cids)
Expand All @@ -1600,7 +1599,7 @@ def delete_contributions(self, query: Optional[dict] = None, timeout: int = -1):
_run_futures(futures, total=total, timeout=timeout)
left, _ = self.get_totals(query=query)
deleted = total - left
self.init_columns(name=query["project"])
self.init_columns(name=name)
self._reinit()
toc = time.perf_counter()
dt = (toc - tic) / 60
Expand Down
Loading