something is up with the mixing scheme

Author: tsmathis

tests/client/test_mprester.py

@@ -563,6 +563,8 @@ def test_get_cohesive_energy(self):
             with MPRester() as mpr:
                 mpr.get_cohesive_energy("mp-1")
 
+    # SOMETHING IS OFF HERE FOR THE MIXING SCHEME
+    # MIXING SCHEME TEST IS FLAKY, PASSES ROUGHLY 20% OF THE TIME
     @pytest.mark.parametrize(
         "thermo_type", ["GGA_GGA+U", ThermoType.GGA_GGA_U_R2SCAN, "r2SCAN"]
     )
@@ -572,6 +574,12 @@ def test_get_stability(self, thermo_type):
         to include more diverse chemical environments and thermo types which
         reflect the scope of the current MP database.
         """
+        if (
+            isinstance(thermo_type, ThermoType)
+            and thermo_type == ThermoType.GGA_GGA_U_R2SCAN
+        ):
+            pytest.skip("See comments about flakiness for mixing scheme")
+
         with MPRester() as mpr:
 
             # No golden test data. Always test on fetched thermo data
@@ -588,6 +596,7 @@ def test_get_stability(self, thermo_type):
 
             for chemsys in chemsys_to_test:
 
+                # RETURN ORDER NOT DETERMINISTIC
                 entries = mpr.get_entries_in_chemsys(
                     chemsys, additional_criteria={"thermo_types": [thermo_type]}
                 )
@@ -600,6 +609,7 @@ def test_get_stability(self, thermo_type):
                         entry_id=f"mod_{entry.entry_id}",
                     )
                     for entry in entries
+                    # MIXING SCHEME - ONLY PASSES IF A "GOOD" ENTRY IS RETURNED FIRST??
                     if entry.entry_id == entries[0].entry_id
                 ]