Skip to content

Commit 5351c9b

Browse files
author
Jason Munro
authored
Switch user-agent to mp-api version (#874)
* Switch user-agent to mp-api version * Linting
1 parent 39eb023 commit 5351c9b

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

mp_api/client/core/client.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@
77
import gzip
88
import itertools
99
import json
10+
import os
1011
import platform
1112
import sys
1213
import warnings
1314
from concurrent.futures import FIRST_COMPLETED, ThreadPoolExecutor, wait
1415
from copy import copy
16+
from importlib.metadata import PackageNotFoundError, version
1517
from json import JSONDecodeError
1618
from math import ceil
1719
from os import environ
@@ -38,10 +40,9 @@
3840
boto3 = None
3941

4042
try:
41-
from pymatgen.core import __version__ as pmg_version # type: ignore
42-
except ImportError: # pragma: no cover
43-
# fallback to root-level import for older pymatgen versions
44-
from pymatgen import __version__ as pmg_version # type: ignore
43+
__version__ = version("mp_api")
44+
except PackageNotFoundError: # pragma: no cover
45+
__version__ = os.getenv("SETUPTOOLS_SCM_PRETEND_VERSION")
4546

4647
# TODO: think about how to migrate from PMG_MAPI_KEY
4748
DEFAULT_API_KEY = environ.get("MP_API_KEY", None)
@@ -160,12 +161,12 @@ def _create_session(api_key, include_user_agent, headers):
160161
session.headers.update(headers)
161162

162163
if include_user_agent:
163-
pymatgen_info = "pymatgen/" + pmg_version
164+
mp_api_info = "mp-api/" + __version__
164165
python_info = f"Python/{sys.version.split()[0]}"
165166
platform_info = f"{platform.system()}/{platform.release()}"
166167
session.headers[
167168
"user-agent"
168-
] = f"{pymatgen_info} ({python_info} {platform_info})"
169+
] = f"{mp_api_info} ({python_info} {platform_info})"
169170

170171
settings = MAPIClientSettings()
171172
max_retry_num = settings.MAX_RETRIES

tests/molecules/test_summary.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"all_fields",
1414
"fields",
1515
"exclude_elements",
16-
"has_props"
16+
"has_props",
1717
]
1818

1919
alt_name_dict = {"formula": "formula_alphabetical", "molecule_ids": "molecule_id"}
@@ -32,6 +32,7 @@
3232
"has_props": [HasProps.orbitals],
3333
} # type: dict
3434

35+
3536
@pytest.mark.skip(reason="Temporary until data adjustments")
3637
@pytest.mark.skipif(
3738
os.environ.get("MP_API_KEY", None) is None, reason="No API key found."

0 commit comments

Comments
 (0)