add basic warning/exception tests to bump cov

Author: esoteric-ephemera

mp_api/client/core/client.py

@@ -198,7 +198,7 @@ def __init__(
             warnings.warn(
                 "Ignoring `monty_decode`, as it is no longer a supported option in `mp_api`."
                 "The client by default returns results consistent with `monty_decode=True`.",
-                category=DeprecationWarning,
+                category=MPRestWarning,
                 stacklevel=2,
             )
 
@@ -1360,7 +1360,7 @@ def new_str(self) -> str:
 
             return (
                 f"\033[4m\033[1m{self.__class__.__name__}"
-                f"<{self.__class__.__base__.__name__}>\033[0;0m\033[0;0m"
+                f"<{orig_rester_name}>\033[0;0m\033[0;0m"
                 f"\n{extra}\n\n"
                 f"\033[1mFields not requested:\033[0;0m\n{fields_not_requested}"
             )

tests/client/test_client.py

@@ -48,17 +48,16 @@
     # "summary",
 ]  # temp
 
-mpr = MPRester()
-
 # Temporarily ignore molecules resters while molecules query operators are changed
-resters_to_test = [
-    rester
-    for rester in mpr._all_resters
-    if (
-        "molecule" not in rester._class_name.lower()
-        and not (pmg_alloys is None and "alloys" in str(rester).lower())
-    )
-]
+with MPRester() as mpr:
+    resters_to_test = [
+        rester
+        for rester in mpr._all_resters
+        if (
+            "molecule" not in rester._class_name.lower()
+            and not (pmg_alloys is None and "alloys" in str(rester).lower())
+        )
+    ]
 
 
 @requires_api_key

tests/client/test_core_client.py

@@ -1,7 +1,11 @@
 import pytest
 
+import json
+
 from mp_api.client import MPRester
 from mp_api.client.core import BaseRester
+from mp_api.client.core.exceptions import MPRestError, MPRestWarning
+from mp_api.client.routes.materials.materials import MaterialsRester
 
 from .conftest import requires_api_key
 
@@ -65,3 +69,28 @@ def test_fields_not_requested_excludes_requested_fields(mpr):
         AttributeError, match="data is available but has not been requested in"
     ):
         deser_doc.tags
+
+    with pytest.raises(AttributeError, match="object has no attribute 'fake_field'"):
+        deser_doc.fake_field
+
+    assert all(
+        substr in str(deser_doc)
+        for substr in ("MPDataDoc", "CoreTaskDoc", "task_id", "Fields not requested")
+    )
+    assert all(
+        substr in deser_doc.__repr__()
+        for substr in ("MPDataDoc", "CoreTaskDoc", "task_id", "fields_not_requested")
+    )
+    assert deser_doc.dict() == deser_doc.model_dump()
+    assert isinstance(json.dumps(deser_doc.dict()), str)
+
+
+def test_warnings_exceptions():
+    with pytest.warns(MPRestWarning, match="Ignoring `monty_decode`"):
+        MaterialsRester(monty_decode=True)
+
+    with pytest.raises(MPRestError, match="Chunk size must be greater than zero"):
+        MaterialsRester()._get_all_documents({}, chunk_size=-1)
+
+    with pytest.raises(MPRestError, match="Number of chunks must be greater than zero"):
+        MaterialsRester()._get_all_documents({}, num_chunks=-1)

tests/client/test_mprester.py

@@ -649,6 +649,35 @@ def test_oxygen_evolution_bad_input(self, mpr):
         with pytest.raises(ValueError, match="No available insertion electrode data"):
             _ = mpr.get_oxygen_evolution("mp-2207", "Al")
 
-    def test_monty_decode_warning(self):
+    def test_warnings_exceptions(self, monkeypatch: pytest.MonkeyPatch):
+        from mp_api.client.core.settings import MAPI_CLIENT_SETTINGS
+
         with pytest.warns(MPRestWarning, match="Ignoring `monty_decode`"):
             MPRester(monty_decode=False)
+
+        with MPRester() as mpr:
+            with pytest.raises(
+                NotImplementedError,
+                match="The MPRester\(\).query method has been replaced",
+            ):
+                mpr.query(some_field=1.0)
+
+            with pytest.warns(
+                MPRestWarning, match="No material found containing task mp-0"
+            ):
+                assert mpr.get_material_id_from_task_id("mp-0") is None
+
+            for attr in mpr._deprecated_attributes:
+                with pytest.warns(
+                    DeprecationWarning, match="Accessing.*data through MPRester\..*"
+                ):
+                    getattr(mpr, attr, None)
+
+            emmet_ver = mpr.get_emmet_version(mpr.endpoint)
+            monkeypatch.setattr(
+                MAPI_CLIENT_SETTINGS, "MIN_EMMET_VERSION", f"{emmet_ver.major + 1}.0.0"
+            )
+            with pytest.warns(
+                MPRestWarning, match="The installed version of the mp-api"
+            ):
+                MPRester()