fix: exclude requested fields from fields_not_requested#1066
Merged
esoteric-ephemera merged 3 commits intoMar 4, 2026
Conversation
akshikari
marked this pull request as ready for review
March 4, 2026 17:09
Collaborator
|
Thanks @akshikari - there's a bit more nuance here with fields that exist in the document model but aren't set in the database. Have added that split + some other tests, will merge once they pass |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is my first contribution so hope this is helpful.
This is a fix for the bug mentioned in #940. Before,
fields_not_requestedincorrectly included fields that were explicitly requested but absent from the DB response. Required piping the requested fields down a few levels in an additionalrequested_fieldsparameter for the_convert_to_modeland_generate_returned_modelmethods. S3 path is unchanged sincerequested_fieldsis optional. Addresses the TODO in commit 87c072e.