Commit a39f6d4
Update FF dependencies. (#1495)
* Update dependencies. Remove mattersim.
* Update pyproject.
* Fix CI: update forcefield dep-group matrix to numpy-limited
The e3nn-limited extra was removed from pyproject.toml but the testing
matrix still referenced it. uv silently skips missing extras, so torch
was never installed, breaking test-forcefields collection.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Fix forcefield and electrode tests for matgl 4.x and emmet-core 0.87
matgl >= 4.0 removed the DGL backend: matgl.config.BACKEND and the
matgl.ext._ase_{dgl,pyg} modules no longer exist, and all potentials
load through the unified matgl.ext.ase.PESCalculator. Update the matgl
calculator branch accordingly, drop the obsolete _set_matgl_backend
helper, and point CHGNet at the PyG weights (BowenD-UCB/CHGNet-PyG-*).
emmet-core 0.87.1 (pulled in by the pymatgen 2026.5.4 bump) dropped the
battery_id argument from InsertionElectrodeDoc.from_entries; battery_id
is now a computed property derived from each entry's material_id, which
is already set before the call. Remove the stale argument.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Remove dead DGL tests and skip guards
matgl >= 4.0 removed the DGL backend, so the DGL-specific forcefield
tests no longer exercise a real code path:
- Drop test_m3gnet_static_maker / test_m3gnet_relax_maker, which
monkeypatched the removed matgl.config.BACKEND to 'DGL'.
- Drop test_m3gnet_pot, skipped for DGL/PyTorch 2.4 incompatibility and
pinned to the legacy M3GNet-MP-2021.2.8 weights matgl 3.x dropped.
- Remove the 'import dgl' fallback and the now-always-true 'dgl is None'
clauses from the CHGNet skip guards, which had been silently skipping
the CHGNet relax tests.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Unpin dependencies and declare conflicting extras via tool.uv
Relax == pins to >= across the strict, strict-forcefields-*, jdftx,
fireworks, torchsim extras and the tests/docs dependency groups so uv is
free to resolve compatible versions; the uv.lock still captures exact
versions for reproducibility. Documented constraints are kept: the
strict-openff pymatgen pin (openff is pymatgen-sensitive) and the
numpy<3 / pymongo / netCDF4 upper bounds.
Add [tool.uv] conflicts declaring the four strict-forcefields-* extras
and strict-openff as mutually exclusive. These pull in incompatible
stacks (nequip needs numpy<2 via matscipy; deepmd/tensorflow and
nequip-allegro need numpy>=2; mace/torch-dftd pin different e3nn/torch),
so uv lock now builds a separate resolution per group instead of failing
to satisfy all at once. Re-enable strict-forcefields-e3nn-limited and add
it to the CI test matrix to keep the matrix in sync with the extras.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Add uv.lock and remove it from gitignore.
* Update uvloc.
* Fix torchsim reporter for torch-sim 0.6 read-only filenames
torch-sim-atomistic 0.6 makes TrajectoryReporter.filenames a read-only
property and opens the trajectory files in the constructor, so the
post-construction 'reporter.filenames = [...]' assignment raised
AttributeError. Resolve the paths up front and pass them into the
constructor instead. Surfaced by unpinning torch-sim-atomistic to >=0.5.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Require torch-sim-atomistic>=0.6.0 and drop filenames compat shim
Pin torch-sim-atomistic to >=0.6.0 now that the reporter code targets
its read-only filenames property, and simplify the handling to mutate
the (already deep-copied) reporter dict in place. Add the torchsim extra
to the [tool.uv] conflicts set: torch-sim 0.6 is incompatible with
strict-forcefields-generic (tensorflow pin), and CI already installs
torchsim in its own isolated job.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Update uvlock.
* Fix jdftx test collection under pytest 9.1
pytest 9.1 rejects a fixture that both declares params= and is overridden
by an indirect @parametrize on the same test, raising 'duplicate
parametrization of task_name' at collection. The task_name fixture is
only consumed by test_taskdoc, which always supplies the value via
indirect parametrization, so drop the redundant fixture params and keep
it a pure indirect fixture. Surfaced by unpinning pytest to >=9.0.3.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Set fail-fast: false on test-forcefields and test-non-ase matrices
A failure in one matrix job was cancelling its still-running siblings,
masking the real per-group results (slow forcefields installs never
finished). Disable fail-fast so each dep-group and split reports
independently.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Cap phonopy<4 to fix Gruneisen force-constants regression
phonopy 4.x changed force-constants/primitive-axis handling, breaking
the phonon.save -> phonopy.load round-trip in the Gruneisen workflow
('Force constants shape disagrees with crystal structure setting').
Unpinning let phonopy float to 4.2.1; cap below the breaking major
version (resolves to 3.5.1) until the workflow is made 4.x-compatible.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Run torch-limited forcefield tests single-process to avoid OOM
The torch-limited dep-group loads the heaviest MLIP stack (matgl +
nequip + torch with bundled CUDA libs). Under 'pytest -n auto' the
parallel xdist workers each hold a copy of the models and exceed the
runner's memory, killing the runner mid-test ('received a shutdown
signal'). Use -n 1 for torch-limited; other groups keep -n auto.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test influence of neb forcefield test
* test influence of neb forcefield test
* update test
* update test
* update test
* update test
* fix test
* fix test
* fix test
* split torch tests further
* deactive more tests
* activate this back in
* grueneisen
* fix import
* fix import
* add more tests back
* switch to mace
* fix tests
* move tests to mace
* fix qha tests
* format
* fix linting
* fix linting
* go back to previous forcefield installations
* remove energy criterion due to forcefield change
* make tests strict again
* make tests strict again and fix accidential changes
* fix linting test files
* upgrade upet
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: jgeorge <janine.george@bam.de>1 parent 48d255c commit a39f6d4
14 files changed
Lines changed: 127 additions & 214 deletions
File tree
- .github/workflows
- .mypy_cache/3.12
- src/atomate2
- common/jobs
- forcefields
- torchsim
- tests
- forcefields
- flows
- jdftx
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
41 | 42 | | |
42 | 43 | | |
43 | | - | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
79 | 80 | | |
80 | 81 | | |
81 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
82 | 86 | | |
83 | 87 | | |
84 | | - | |
| 88 | + | |
| 89 | + | |
85 | 90 | | |
86 | 91 | | |
87 | 92 | | |
| |||
113 | 118 | | |
114 | 119 | | |
115 | 120 | | |
| 121 | + | |
116 | 122 | | |
117 | 123 | | |
118 | 124 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
| |||
Whitespace-only changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
51 | 54 | | |
52 | 55 | | |
53 | 56 | | |
| |||
60 | 63 | | |
61 | 64 | | |
62 | 65 | | |
63 | | - | |
| 66 | + | |
64 | 67 | | |
65 | 68 | | |
66 | 69 | | |
| |||
95 | 98 | | |
96 | 99 | | |
97 | 100 | | |
98 | | - | |
99 | | - | |
100 | | - | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
101 | 104 | | |
102 | 105 | | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
| 106 | + | |
113 | 107 | | |
114 | | - | |
115 | 108 | | |
| 109 | + | |
116 | 110 | | |
117 | | - | |
| 111 | + | |
118 | 112 | | |
119 | 113 | | |
120 | 114 | | |
121 | 115 | | |
122 | | - | |
123 | 116 | | |
124 | 117 | | |
125 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | | - | |
206 | | - | |
207 | | - | |
| 205 | + | |
208 | 206 | | |
209 | 207 | | |
210 | 208 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
304 | 304 | | |
305 | 305 | | |
306 | 306 | | |
307 | | - | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
308 | 311 | | |
309 | 312 | | |
310 | 313 | | |
| |||
349 | 352 | | |
350 | 353 | | |
351 | 354 | | |
352 | | - | |
353 | | - | |
354 | | - | |
355 | | - | |
356 | | - | |
357 | | - | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
358 | 364 | | |
359 | 365 | | |
360 | | - | |
361 | | - | |
362 | 366 | | |
363 | | - | |
364 | 367 | | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | | - | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
369 | 371 | | |
370 | 372 | | |
371 | 373 | | |
| |||
376 | 378 | | |
377 | 379 | | |
378 | 380 | | |
379 | | - | |
380 | | - | |
381 | | - | |
382 | 381 | | |
383 | 382 | | |
384 | 383 | | |
385 | 384 | | |
386 | | - | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
| 385 | + | |
393 | 386 | | |
394 | 387 | | |
395 | 388 | | |
| |||
440 | 433 | | |
441 | 434 | | |
442 | 435 | | |
443 | | - | |
444 | | - | |
445 | | - | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
446 | 441 | | |
447 | 442 | | |
448 | 443 | | |
| |||
492 | 487 | | |
493 | 488 | | |
494 | 489 | | |
495 | | - | |
496 | | - | |
497 | | - | |
498 | | - | |
499 | | - | |
500 | | - | |
501 | | - | |
502 | | - | |
503 | | - | |
504 | | - | |
505 | | - | |
506 | | - | |
507 | | - | |
508 | | - | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
518 | | - | |
519 | | - | |
520 | | - | |
521 | | - | |
522 | | - | |
523 | | - | |
524 | | - | |
525 | | - | |
526 | 490 | | |
527 | 491 | | |
528 | 492 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
166 | 171 | | |
167 | 172 | | |
168 | 173 | | |
169 | 174 | | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | 175 | | |
175 | 176 | | |
176 | 177 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
38 | 37 | | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
43 | | - | |
44 | | - | |
45 | 42 | | |
46 | 43 | | |
47 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
36 | 43 | | |
37 | 44 | | |
38 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | | - | |
195 | | - | |
196 | | - | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
197 | 199 | | |
198 | 200 | | |
199 | 201 | | |
| |||
229 | 231 | | |
230 | 232 | | |
231 | 233 | | |
232 | | - | |
233 | | - | |
234 | | - | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
235 | 239 | | |
236 | 240 | | |
237 | 241 | | |
| |||
0 commit comments