Correct layout and functionalities#493
Merged
tschaume merged 9 commits intomaterialsproject:mainfrom Nov 4, 2025
Merged
Conversation
Collaborator
Author
Collaborator
Author
tschaume
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Original error:
The concentration/composition inputs appear after heatmap entries are provided, but they should appear immediately after Pourbaix entries are entered.
Root cause:
Several callbacks have interdependent triggers, and their execution order isn’t controlled correctly.
TODO:
Takeaway:
Avoid using
MPComponent.get_all_kwargs_id()as anInputin multiple callbacks—typing or minor changes in any child will fire callbacks unexpectedly. Use it only for a single, dedicated callback when sub-components are generated dynamically, and you can’t explicitly list triggers. Otherwise, prefer explicit Inputs (or dict/pattern IDs) and use State for values that shouldn’t trigger. (mpclimits the ID format—so for this repo, keepingMPComponent.get_all_kwargs_id())Don’t create your main components inside callbacks. Put stable containers in the initial layout and add dynamic sub-components to their
children. This avoids common errors like “component id not found” and “duplicate id.”