Remove unused copy_contcar_to_poscar_if_valid function#420
Merged
Conversation
In #416, after the rebase, a utility function `copy_contcar_to_poscar_if_valid` was added. But it is unused. We should remove the unused code.
Member
Author
|
@janosh: Just a head's up on this PR. I can't find any place it's used, so I will remove it. But please let me know if there is something I am missing. Apologies for not flagging this earlier --- I think I missed it during the rebase. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 49.73% 53.73% +4.00%
==========================================
Files 39 39
Lines 3567 3562 -5
==========================================
+ Hits 1774 1914 +140
+ Misses 1793 1648 -145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
thanks for noticing! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #416, after the rebase, a utility function
copy_contcar_to_poscar_if_validwas added. But it is unused. We should remove the unused code.