Skip to content

Make is_valid_poscar less noisy#422

Merged
Andrew-S-Rosen merged 2 commits into
masterfrom
Andrew-S-Rosen-patch-1
Dec 14, 2025
Merged

Make is_valid_poscar less noisy#422
Andrew-S-Rosen merged 2 commits into
masterfrom
Andrew-S-Rosen-patch-1

Conversation

@Andrew-S-Rosen
Copy link
Copy Markdown
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Dec 14, 2025

Summary

Closes #421. Since is_valid_poscar will return False very frequently, we should not have warning-level logging messages sent to the user in such instances.

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.66%. Comparing base (20cefaf) to head (ba22dc8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   53.73%   53.66%   -0.07%     
==========================================
  Files          39       39              
  Lines        3562     3557       -5     
==========================================
- Hits         1914     1909       -5     
  Misses       1648     1648              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Andrew-S-Rosen Andrew-S-Rosen merged commit 312d4cf into master Dec 14, 2025
8 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the Andrew-S-Rosen-patch-1 branch December 14, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Noisy/unclear logging when attempting to move CONTCAR to POSCAR

2 participants