Skip to content

Rename cumulative (typo?)#1675

Merged
affeldt-aist merged 4 commits into
math-comp:masterfrom
Yosuke-Ito-345:correct_cumulative_bounded
Jul 6, 2025
Merged

Rename cumulative (typo?)#1675
affeldt-aist merged 4 commits into
math-comp:masterfrom
Yosuke-Ito-345:correct_cumulative_bounded

Conversation

@Yosuke-Ito-345

@Yosuke-Ito-345 Yosuke-Ito-345 commented Jul 5, 2025

Copy link
Copy Markdown
Collaborator
Motivation for this change

It is a small change, but cumulativeNy0 and cumulativey1 in lebesgue_stieltjes_measure.v should be renamed?

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist

Copy link
Copy Markdown
Member

That makes sense, could you document the change in the changelog also?

@Yosuke-Ito-345

Copy link
Copy Markdown
Collaborator Author

Thank you for the comment. I will add it.
Also I'm going to modify probability.v...

@Yosuke-Ito-345 Yosuke-Ito-345 force-pushed the correct_cumulative_bounded branch from 0ad4911 to cc1b4c8 Compare July 5, 2025 11:51
@Yosuke-Ito-345

Copy link
Copy Markdown
Collaborator Author

The checks have passed!
It's ready for review.

Comment thread CHANGELOG_UNRELEASED.md Outdated
@affeldt-aist affeldt-aist merged commit 7528cc1 into math-comp:master Jul 6, 2025
34 checks passed
@Yosuke-Ito-345

Copy link
Copy Markdown
Collaborator Author

Thank you for the review and the merge.

@Yosuke-Ito-345 Yosuke-Ito-345 deleted the correct_cumulative_bounded branch July 14, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants