Rename cumulative (typo?)#1675
Merged
affeldt-aist merged 4 commits intoJul 6, 2025
Merged
Conversation
Member
|
That makes sense, could you document the change in the changelog also? |
Collaborator
Author
|
Thank you for the comment. I will add it. |
0ad4911 to
cc1b4c8
Compare
Collaborator
Author
|
The checks have passed! |
affeldt-aist
reviewed
Jul 6, 2025
Collaborator
Author
|
Thank you for the review and the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It is a small change, but
cumulativeNy0andcumulativey1inlebesgue_stieltjes_measure.vshould be renamed?Checklist
added corresponding entries in
CHANGELOG_UNRELEASED.mdadded corresponding documentation in the headers
Reference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers