Skip to content

mv squeeze for R earlier#2004

Merged
affeldt-aist merged 1 commit into
math-comp:masterfrom
affeldt-aist:metric_20260622
Jun 28, 2026
Merged

mv squeeze for R earlier#2004
affeldt-aist merged 1 commit into
math-comp:masterfrom
affeldt-aist:metric_20260622

Conversation

@affeldt-aist

Copy link
Copy Markdown
Member
Motivation for this change

This PR is essentially moving squeeze_cvgr from normed_module.v to the topology_theory directory
so that it is available to develop the theory of TVSs.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist requested a review from mkerjean June 23, 2026 07:46
@affeldt-aist

affeldt-aist commented Jun 27, 2026

Copy link
Copy Markdown
Member Author

CI green (fyi: @mkerjean )

@affeldt-aist affeldt-aist changed the title mv sequeeze for R earlier mv squeeze for R earlier Jun 27, 2026

@mkerjean mkerjean left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. As the CI is green it can be merged. Could you explain why the necessity to duplicate cvgrPdistC_lt or cvgr_distC_lt ? Would solving it necessitate the creation of a pseudometric type?

@affeldt-aist

Copy link
Copy Markdown
Member Author

Looks great, thanks. As the CI is green it can be merged. Could you explain why the necessity to duplicate cvgrPdistC_lt or cvgr_distC_lt ?

By putting a Let here, I can prove the needed lemma with a minimal assumption (R : numFieldType)
and I do not commit to anything (it is a Let, it can't be used outside).
If I were to put cvgrPdistC_lt in the module metricType_numDomainType along with other generalizations
(generalizations from normed modules to metric space, WIP),
I would need R : realFieldType to be able to use mdist x y = mdist y x,
which would cause the section (with the lemmas real_cvgr_lt, etc.) to require R : realFieldType instead of numFieldType, which would be a regression compared with the current state of MathComp-Analysis.

So this is really just a way to make an incremental progress (put the squeeze theorem in the right place and
move a minimal set of lemmas without losing "generality") and defer big changes (generalization of more lemmas
to metric spaces) to later.

Would solving it necessitate the creation of a pseudometric type?

Sorry, I can't see it. Which type are you thinking of? Pseudometric in the MCA sense or in the sense "d(x,y)=0 does not necessarily imply x=y"? In the latter case, it does not seem to be the incriminating property, that's why I can't see how it would help right away.

@affeldt-aist affeldt-aist merged commit 285d2be into math-comp:master Jun 28, 2026
45 checks passed
@affeldt-aist affeldt-aist deleted the metric_20260622 branch June 28, 2026 14:42
Brixfoly pushed a commit to Brixfoly/analysis that referenced this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants