Fix __getitem__ in LabelTensor#546
Merged
Merged
Conversation
FilippoOlivo
added
bug
GiovanniCanali
approved these changes
Apr 11, 2025
Collaborator
GiovanniCanali
left a comment
GiovanniCanali
left a comment
There was a problem hiding this comment.
Everything ok for me, @FilippoOlivo! Check comment on missing docstring!
dario-coscia
requested changes
Apr 11, 2025
|
|
||
| old_dof = old_labels[to_update_dim]["dof"] | ||
| old_dof = old_labels[dim]["dof"] | ||
| label_name = old_labels[dim]["name"] |
Collaborator
There was a problem hiding this comment.
why do we use old_labels and don't simply pass self.labels?
* rm print
dario-coscia
approved these changes
Apr 14, 2025
Collaborator
|
@FilippoOlivo great PR! I removed a print statement which was left unintentionally. I'll wait for the tests to run, and if all pass, I will merge in the master. Great job! |
Collaborator
|
All tests passed, except for coverage, which is linked to #548. Merge in master |
FilippoOlivo
added a commit
to FilippoOlivo/PINA
that referenced
this pull request
Apr 17, 2025
* Fix LabelTensor * Cleaning label_tensor.py --------- Co-authored-by: Dario Coscia <93731561+dario-coscia@users.noreply.github.com>
dario-coscia
added a commit
that referenced
this pull request
Apr 17, 2025
* Fix LabelTensor * Cleaning label_tensor.py --------- Co-authored-by: Dario Coscia <93731561+dario-coscia@users.noreply.github.com>
GiovanniCanali
pushed a commit
to GiovanniCanali/PINA
that referenced
this pull request
Dec 2, 2025
* Fix LabelTensor * Cleaning label_tensor.py --------- Co-authored-by: Dario Coscia <93731561+dario-coscia@users.noreply.github.com>
GiovanniCanali
pushed a commit
to GiovanniCanali/PINA
that referenced
this pull request
Dec 2, 2025
* Fix LabelTensor * Cleaning label_tensor.py --------- Co-authored-by: Dario Coscia <93731561+dario-coscia@users.noreply.github.com>
GiovanniCanali
pushed a commit
to GiovanniCanali/PINA
that referenced
this pull request
Dec 2, 2025
* Fix LabelTensor * Cleaning label_tensor.py --------- Co-authored-by: Dario Coscia <93731561+dario-coscia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #545